• Robert Griesemer's avatar
    go/printer: remove notion of "Styler", remove HTML mode · d916cca3
    Robert Griesemer authored
    Neither gofmt nor godoc are making use of a Styler (for
    token-specific formatting) anymore. Stylers interacted in complicated
    ways with HTML-escaping which was why the printer needed an HTML mode
    in the first place.
    
    godoc now uses a more powerful and general text formatting
    function that does HTML escaping, text selection, and can
    handle token-specific formatting if so desired (currently
    used only for comments).
    
    As a consequence, cleaned up uses of go/printer in godoc;
    simplified the various write utility functions, and also
    removed the need for the "html" template format (in favor of
    html-esc which now does the same and is used more pervasively).
    
    Applied gofmt -w src misc to verify no changes occured,
    and tested godoc manually.
    
    There should be no visible changes except that (type) code
    snippets presented for godoc package documentation now
    uses the same formatting as for general source code and
    thus comments get the comment-specific color here as well
    (not the case at the moment).
    
    (TODO: godoc needs a good automatic test suite).
    
    R=rsc
    CC=golang-dev
    https://golang.org/cl/4152042
    d916cca3
snippet.go 2.53 KB