• Ian Lance Taylor's avatar
    net: use runtime.Keepalive for *netFD values · 873dca4c
    Ian Lance Taylor authored
    The net package sets a finalizer on *netFD. I looked through all the
    uses of *netFD in the package, looking for each case where a *netFD
    was passed as an argument and the final reference to the argument was
    not a function or method call. I added a call to runtime.KeepAlive after
    each such final reference (there were only three).
    
    The code is safe today without the KeepAlive calls because the compiler
    keeps arguments alive for the duration of the function. However, that is
    not a language requirement, so adding the KeepAlive calls ensures that
    this code remains safe even if the compiler changes in the future.
    
    Change-Id: I4e2bd7c5a946035dc509ccefb4828f72335a9ee3
    Reviewed-on: https://go-review.googlesource.com/27650
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    873dca4c
fd_poll_runtime.go 2.99 KB