• Hiroshi Ioka's avatar
    path/filepath: make TestToNorm robust · 643c6b3c
    Hiroshi Ioka authored
    The old code leaves garbages in a temporary directory because it
    cannot remove the current working directory on windows.
    The new code changes the directory before calling os.Remove.
    
    Furthermore, the old code assumes that ioutil.TempDir (os.TempDir)
    doesn't return a relative path nor an UNC path.
    If it isn't the case, the new code calls t.Fatal earlier for preventing
    ambiguous errors.
    
    Finally, the old code reassigns the variable which is used by the defer
    function. It could cause unexpected results, so avoid that.
    
    Change-Id: I5fc3902059ecaf18dc1341ecc4979d1206034cd7
    Reviewed-on: https://go-review.googlesource.com/31790
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAlex Brainman <alex.brainman@gmail.com>
    643c6b3c
path_windows_test.go 12 KB