• David Lazar's avatar
    runtime: handle inlined calls in runtime.Callers · ee97216a
    David Lazar authored
    The `skip` argument passed to runtime.Caller and runtime.Callers should
    be interpreted as the number of logical calls to skip (rather than the
    number of physical stack frames to skip). This changes runtime.Callers
    to skip inlined calls in addition to physical stack frames.
    
    The result value of runtime.Callers is a slice of program counters
    ([]uintptr) representing physical stack frames. If the `skip` parameter
    to runtime.Callers skips part-way into a physical frame, there is no
    convenient way to encode that in the resulting slice. To avoid changing
    the API in an incompatible way, our solution is to store the number of
    skipped logical calls of the first frame in the _second_ uintptr
    returned by runtime.Callers. Since this number is a small integer, we
    encode it as a valid PC value into a small symbol called:
    
        runtime.skipPleaseUseCallersFrames
    
    For example, if f() calls g(), g() calls `runtime.Callers(2, pcs)`, and
    g() is inlined into f, then the frame for f will be partially skipped,
    resulting in the following slice:
    
        pcs = []uintptr{pc_in_f, runtime.skipPleaseUseCallersFrames+1, ...}
    
    We store the skip PC in pcs[1] instead of pcs[0] so that `pcs[i:]` will
    truncate the captured stack trace rather than grow it for all i.
    
    Updates #19348.
    
    Change-Id: I1c56f89ac48c29e6f52a5d085567c6d77d499cf1
    Reviewed-on: https://go-review.googlesource.com/37854
    Run-TryBot: David Lazar <lazard@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAustin Clements <austin@google.com>
    ee97216a
asm.s 1.25 KB