• Filippo Valsorda's avatar
    crypto/tls: implement TLS 1.3 middlebox compatibility mode · dc0be727
    Filippo Valsorda authored
    Looks like the introduction of CCS records in the client second flight
    gave time to s_server to send NewSessionTicket messages in between the
    client application data and close_notify. There seems to be no way of
    turning NewSessionTicket messages off, neither by not sending a
    psk_key_exchange_modes extension, nor by command line flag.
    
    Interleaving the client write like that tickled an issue akin to #18701:
    on Windows, the client reaches Close() before the last record is drained
    from the send buffer, the kernel notices and resets the connection,
    cutting short the last flow. There is no good way of synchronizing this,
    so we sleep for a RTT before calling close, like in CL 75210. Sigh.
    
    Updates #9671
    
    Change-Id: I44dc1cca17b373695b5a18c2741f218af2990bd1
    Reviewed-on: https://go-review.googlesource.com/c/147419
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAdam Langley <agl@golang.org>
    dc0be727
Client-TLSv13-ALPN 9.37 KB