• Didier Spezia's avatar
    net/http/fcgi: fix panic with malformed params record · b7fa4f27
    Didier Spezia authored
    As stated in FastCGI specifications:
    
    FastCGI transmits a name-value pair as the length of the name,
    followed by the length of the value, followed by the name,
    followed by the value.
    
    The current implementation trusts the name and value length
    provided in the record, leading to a panic if the record
    is malformed.
    
    Added an explicit check on the lengths.
    
    Test case and fix suggested by diogin@gmail.com (Jingcheng Zhang)
    
    Fixes #11824
    
    Change-Id: I883a1982ea46465e1fb02e0e02b6a4df9e529ae4
    Reviewed-on: https://go-review.googlesource.com/15015Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    b7fa4f27
fcgi_test.go 6.59 KB