• Rui Ueyama's avatar
    undo CL 101330053 / c19c9a063fe8 · a200e0b8
    Rui Ueyama authored
    sync.Pool is not supposed to be used everywhere, but is
    a last resort.
    
    ««« original CL description
    strings: use sync.Pool to cache buffer
    
    benchmark                         old ns/op    new ns/op    delta
    BenchmarkByteReplacerWriteString       3596         3094  -13.96%
    
    benchmark                        old allocs   new allocs    delta
    BenchmarkByteReplacerWriteString          1            0  -100.00%
    
    LGTM=dvyukov
    R=bradfitz, dave, dvyukov
    CC=golang-codereviews
    https://golang.org/cl/101330053
    »»»
    
    LGTM=dave
    R=r, dave
    CC=golang-codereviews
    https://golang.org/cl/102610043
    a200e0b8
replace_test.go 12.8 KB