• David Chase's avatar
    cmd/internal/gc: make indirect calls properly escape-y · b19ec684
    David Chase authored
    Indirect function and method calls should leak everything,
    but they didn't.
    
    This fix had no particular effect on the cost of running the
    compiler on html/template/*.go and added a single new "escape"
    to the standard library:
    
        syscall/syscall_unix.go:85: &b[0] escapes to heap
    in
    	if errno := m.munmap(uintptr(unsafe.Pointer(&b[0])),
    	                     uintptr(len(b))); errno != nil {
    
    Added specific escape testing to escape_calls.go
    (and verified that it fails without this patch)
    
    I also did a little code cleanup around the changes in esc.c.
    
    Fixes #10925
    
    Change-Id: I9984b701621ad4c49caed35b01e359295c210033
    Reviewed-on: https://go-review.googlesource.com/10295Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    b19ec684
esc.go 48.9 KB