• Robert Griesemer's avatar
    cmd/compile/internal/syntax: replace inlined statement lists with syntax.BlockStmt · b5f81eae
    Robert Griesemer authored
    This simplifies the code and removes a premature optimization.
    It increases the amount of allocated syntax.Node space by ~0.4%
    for parsing all of std lib, which is negligible.
    
    Before the change (best of 5 runs):
    
      $ go test -run StdLib -fast
      parsed 1517022 lines (3394 files) in 793.487886ms (1911840 lines/s)
      allocated 387.086Mb (267B/line, 487.828Mb/s)
    
    After the change (best of 5 runs):
    
      $ go test -run StdLib -fast
      parsed 1516911 lines (3392 files) in 805.028655ms (1884294 lines/s)
      allocated 388.466Mb (268B/line, 482.549Mb/s)
    
    Change-Id: Id19d6210fdc62393862ba3b04913352d95c599be
    Reviewed-on: https://go-review.googlesource.com/38439
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    b5f81eae
nodes_test.go 8.69 KB