• Matthew Dempsky's avatar
    reflect: fix mutability of non-exported embedded fields · 6471ace2
    Matthew Dempsky authored
    The reflect API normally grants only read-only access to non-exported
    fields, but it specially handles non-exported embedded fields so that
    users can still fully access promoted fields and methods. For example,
    if v.Field(i) refers to a non-exported embedded field, it would be
    limited to RO access. But if v.Field(i).Field(j) is an exported field,
    then the resulting Value will have full access.
    
    However, the way this was implemented allowed other operations to be
    interspersed between the Field calls, which could grant inappropriate
    access.
    
    Relatedly, Elem() is safe to use on pointer-embeddings, but it was
    also being allowed on embeddings of interface types. This is
    inappropriate because it could allow accessing methods of the dynamic
    value's complete method set, not just those that were promoted via the
    interface embedding.
    
    Fixes #22031.
    Fixes #22053.
    
    Change-Id: I9db9be88583f1c1d80c1b4705a76f23a4379182f
    Reviewed-on: https://go-review.googlesource.com/66331
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    6471ace2
all_test.go 159 KB