• Russ Cox's avatar
    encoding/hex: make Decode, Decoder, DecodeString agree about partial results and errors · d0ce197c
    Russ Cox authored
    CL 70210 added Decoder for #21590, and in doing so it changed
    the existing func Decode to return partial results for decoding errors.
    That seems like a good change to make to Decode, but it was
    untested (except as used by Decoder), inconsistent with DecodeString
    in all error cases, and inconsistent with Decoder in not returning
    partial results for odd-length input strings.
    
    This CL makes Decode, DecodeString, and Decoder all agree about
    the handling of partial results (they are returned) and error
    precedence (the error earliest in the input is reported),
    and it documents and tests this.
    
    Change-Id: Ifb7d1e100ecb66fe2ed5ba34a621084d480f16db
    Reviewed-on: https://go-review.googlesource.com/78120
    Run-TryBot: Russ Cox <rsc@golang.org>
    Reviewed-by: 's avatarJoe Tsai <thebrokentoaster@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    d0ce197c
hex.go 7.76 KB