• Alex Brainman's avatar
    os: reimplement windows os.Stat · 53003621
    Alex Brainman authored
    Currently windows Stat uses combination of Lstat and Readlink to
    walk symlinks until it reaches file or directory. Windows Readlink
    is implemented via Windows DeviceIoControl(FSCTL_GET_REPARSE_POINT, ...)
    call, but that call does not work on network shares or inside of
    Docker container (see issues #18555 ad #19922 for details).
    
    But Raymond Chen suggests different approach:
    https://blogs.msdn.microsoft.com/oldnewthing/20100212-00/?p=14963/
    - he suggests to use Windows I/O manager to dereferences the
    symbolic link.
    
    This appears to work for all normal symlinks, but also for network
    shares and inside of Docker container.
    
    This CL implements described procedure.
    
    I also had to adjust TestStatSymlinkLoop, because the test is
    expecting Stat to return syscall.ELOOP for symlink with a loop.
    But new Stat returns Windows error of ERROR_CANT_RESOLVE_FILENAME
    = 1921 instead. I could map ERROR_CANT_RESOLVE_FILENAME into
    syscall.ELOOP, but I suspect the former is broader than later.
    And ERROR_CANT_RESOLVE_FILENAME message text of "The name of
    the file cannot be resolved by the system." sounds fine to me.
    
    Fixes #10935
    Fixes #18555
    Fixes #19922
    
    Change-Id: I979636064cdbdb9c7c840cf8ae73fe2c24499879
    Reviewed-on: https://go-review.googlesource.com/41834Reviewed-by: 's avatarHarshavardhana <hrshvardhana@gmail.com>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    53003621
os_windows_test.go 21.4 KB