• Austin Clements's avatar
    runtime: document assumption about wbBufFlush argument slots · b800f202
    Austin Clements authored
    gcWriteBarrier and wbBufFlush assume that not writing to an argument
    variable is sufficient to not clobber the corresponding argument slot.
    This assumption lets us simplify the write barrier assembly code,
    speed up the flush path, and reduce the stack usage of the write
    barrier.
    
    But it is an assumption, so this CL documents it to make this clear.
    
    Alternatively, we could separate the register spill slots from the
    argument slots in the write barrier, but that loses the advantages
    above. On the other hand, it's extremely unlikely that we'll change
    the behavior of the compiler to start clobbering argument slots (if
    anything, we'd probably change it to *not* clobber argument slots even
    if you wrote to the arguments).
    
    Fixes #25512.
    
    Change-Id: Ib2cf29c0d90956ca02b997ef6e7fa56fc8044efe
    Reviewed-on: https://go-review.googlesource.com/127815Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
    b800f202
mwbbuf.go 9.01 KB