• Matthew Dempsky's avatar
    cmd/pack: fix export data truncation bug · 3d7042fb
    Matthew Dempsky authored
    The binary export data format includes escaping to prevent "\n$$" from
    appearing internally, but not "\n!\n". This could result in a false
    positive when cmd/pack searched for "\n!\n" as the delimiter between
    package definition and linker object.
    
    To address this, this CL changes cmd/pack to also be aware of the
    "\n$$" markers, and to ignore "\n!\n" within the export data.
    
    Fixes #21703.
    
    Change-Id: I71ea8ba49dbd066c7afb7717ddc0190e38fe5649
    Reviewed-on: https://go-review.googlesource.com/60773
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    3d7042fb
pack_test.go 9.57 KB