• Matthew Dempsky's avatar
    cmd/compile: fix typechecking of untyped boolean expressions · d3f6d11d
    Matthew Dempsky authored
    Previously, if we typechecked a statement like
    
        var x bool = p1.f == p2.f && p1.g == p2.g
    
    we would correctly update the '&&' node's type from 'untyped bool' to
    'bool', but the '==' nodes would stay 'untyped bool'. This is
    inconsistent, and caused consistency checks during walk to fail.
    
    This CL doesn't pass toolstash because it seems to slightly affect the
    register allocator's heuristics. (Presumably 'untyped bool's were
    previously making it all the way through SSA?)
    
    Fixes #23414.
    
    Change-Id: Ia85f8cfc69b5ba35dfeb157f4edf57612ecc3285
    Reviewed-on: https://go-review.googlesource.com/94022
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
    d3f6d11d
const.go 32.9 KB