• Austin Clements's avatar
    runtime: unwind stack barriers when writing above the current frame · 306f8f11
    Austin Clements authored
    Stack barriers assume that writes through pointers to frames above the
    current frame will get write barriers, and hence these frames do not
    need to be re-scanned to pick up these changes. For normal writes,
    this is true. However, there are places in the runtime that use
    typedmemmove to potentially write through pointers to higher frames
    (such as mapassign1). Currently, typedmemmove does not execute write
    barriers if the destination is on the stack. If there's a stack
    barrier between the current frame and the frame being modified with
    typedmemmove, and the stack barrier is not otherwise hit, it's
    possible that the garbage collector will never see the updated pointer
    and incorrectly reclaim the object.
    
    Fix this by making heapBitsBulkBarrier (which lies behind typedmemmove
    and its variants) detect when the destination is in the stack and
    unwind stack barriers up to the point, forcing mark termination to
    later rescan the effected frame and collect these pointers.
    
    Fixes #11084. Might be related to #10240, #10541, #10941, #11023,
     #11027 and possibly others.
    
    Change-Id: I323d6cd0f1d29fa01f8fc946f4b90e04ef210efd
    Reviewed-on: https://go-review.googlesource.com/10791Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    306f8f11
panic1.go 3.73 KB