• Keith Randall's avatar
    [release-branch.go1.8] cmd/compile: fix store chain in schedule pass · 1054085d
    Keith Randall authored
    Cherry-pick of CL 43294.
    
    Tuple ops are weird. They are essentially a pair of ops,
    one which consumes a mem and one which generates a mem (the Select1).
    The schedule pass didn't handle these quite right.
    
    Fix the scheduler to include both parts of the paired op in
    the store chain. That makes sure that loads are correctly ordered
    with respect to the first of the pair.
    
    Add a check for the ssacheck builder, that there is only one
    live store at a time. I thought we already had such a check, but
    apparently not...
    
    Fixes #20335
    
    Change-Id: I59eb3446a329100af38d22820b1ca2190ca46a78
    Reviewed-on: https://go-review.googlesource.com/43411
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    1054085d
check.go 9.58 KB