• David Chase's avatar
    cmd/compile: add explicit 'where' to EscStep data for explanations · bea5252a
    David Chase authored
    Sometimes neither the src nor the dst of an escape edge
    contains the line number appropriate to the edge, so add
    a field so that can be set correctly.
    
    Also updated some of the explanations to be less jargon-y
    and perhaps more informative, and folded bug example into
    test.
    
    Cleaned up some of the function/method names in esc.go
    and did a quick sanity check that each "bundling" function
    was actually called often enough to justify its existence.
    
    Fixes #17459.
    
    Change-Id: Ieba53ab0a6ba1f7a6c4962bc0b702ede9cc3a3cc
    Reviewed-on: https://go-review.googlesource.com/31660
    Run-TryBot: David Chase <drchase@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
    bea5252a
escape_because.go 7.52 KB