Commit 0a81d31b authored by David Crawshaw's avatar David Crawshaw

runtime/pprof: skip fork test on darwin/arm64

Just like darwin/arm.

Change-Id: Ic75927bd6457d37cda7dd8279fd9b4cd52edc1d1
Reviewed-on: https://go-review.googlesource.com/8813Reviewed-by: 's avatarMinux Ma <minux@golang.org>
parent 2ce82c6c
...@@ -122,7 +122,10 @@ func parseProfile(t *testing.T, bytes []byte, f func(uintptr, []uintptr)) { ...@@ -122,7 +122,10 @@ func parseProfile(t *testing.T, bytes []byte, f func(uintptr, []uintptr)) {
func testCPUProfile(t *testing.T, need []string, f func()) { func testCPUProfile(t *testing.T, need []string, f func()) {
switch runtime.GOOS { switch runtime.GOOS {
case "darwin": case "darwin":
if runtime.GOARCH != "arm" { switch runtime.GOARCH {
case "arm", "arm64":
// nothing
default:
out, err := exec.Command("uname", "-a").CombinedOutput() out, err := exec.Command("uname", "-a").CombinedOutput()
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
...@@ -207,8 +210,9 @@ func testCPUProfile(t *testing.T, need []string, f func()) { ...@@ -207,8 +210,9 @@ func testCPUProfile(t *testing.T, need []string, f func()) {
// Ensure that we do not do this. // Ensure that we do not do this.
func TestCPUProfileWithFork(t *testing.T) { func TestCPUProfileWithFork(t *testing.T) {
if runtime.GOOS == "darwin" { if runtime.GOOS == "darwin" {
if runtime.GOARCH == "arm" { switch runtime.GOARCH {
t.Skipf("skipping on darwin/arm") case "arm", "arm64":
t.Skipf("skipping on %s/%s, cannot fork", runtime.GOOS, runtime.GOARCH)
} }
} }
......
...@@ -21,6 +21,11 @@ func skipTraceTestsIfNeeded(t *testing.T) { ...@@ -21,6 +21,11 @@ func skipTraceTestsIfNeeded(t *testing.T) {
switch runtime.GOOS { switch runtime.GOOS {
case "solaris": case "solaris":
t.Skip("skipping: solaris timer can go backwards (http://golang.org/issue/8976)") t.Skip("skipping: solaris timer can go backwards (http://golang.org/issue/8976)")
case "darwin":
switch runtime.GOARCH {
case "arm", "arm64":
t.Skipf("skipping on %s/%s, cannot fork", runtime.GOOS, runtime.GOARCH)
}
} }
switch runtime.GOARCH { switch runtime.GOARCH {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment