Commit 0c38d789 authored by Wei Xiao's avatar Wei Xiao Committed by Brad Fitzpatrick

cmd/go: fix TestBuildIDContainsArchModeEnv fail on arm64

TestBuildIDContainsArchModeEnv fails on arm64 because defaultGO386 has
different value from x86 (amd64/386). On arm64 defaultGO386 = '387' but
on x86 defaultGO386 = 'sse2'. The difference will make the test succeed
on x86 while fail on arm64 since it generates the same build ID.
Fix it by explicitly setting GO386 instead of using default value

Fixes #20608

Change-Id: I864b0e47325942d9513516bdf47f60391d18c0d0
Reviewed-on: https://go-review.googlesource.com/45112Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
parent 32d42fb6
...@@ -4158,7 +4158,7 @@ func main() {}`) ...@@ -4158,7 +4158,7 @@ func main() {}`)
tg.setenv("GOARCH", "386") tg.setenv("GOARCH", "386")
tg.setenv("GO386", "387") tg.setenv("GO386", "387")
}, func() { }, func() {
tg.setenv("GO386", "") tg.setenv("GO386", "sse2")
})) }))
t.Run("arm", testWith(func() { t.Run("arm", testWith(func() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment