Commit 1242c767 authored by Rob Pike's avatar Rob Pike Committed by Russ Cox

reflect: make allocation test less fragile.

When GOMAXPROCS>1, the testing framework runs in parallel with the
test itself and may do a small number of allocations, so allow the
"noAllocs" condition to admit just a few.

Fixes #1782.

R=rsc
CC=golang-dev, rsc
https://golang.org/cl/4533041
parent b96fc594
......@@ -1451,7 +1451,9 @@ func noAlloc(t *testing.T, n int, f func(int)) {
for j := 0; j < n; j++ {
f(j)
}
if runtime.MemStats.Mallocs != 0 {
// A few allocs may happen in the testing package when GOMAXPROCS > 1, so don't
// require zero mallocs.
if runtime.MemStats.Mallocs > 5 {
t.Fatalf("%d mallocs after %d iterations", runtime.MemStats.Mallocs, n)
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment