Commit 163653ee authored by Hyang-Ah Hana Kim's avatar Hyang-Ah Hana Kim

go/build: test code cleanup: remove unnecessary func var

The earlier calls to test(false) in TestDependencies were
removed by https://golang.org/cl/12576

Change-Id: If5c7994172379c2d7f633d2e9c5261e668c754fa
Reviewed-on: https://go-review.googlesource.com/16117Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
parent 08d04ba2
...@@ -456,26 +456,23 @@ func TestDependencies(t *testing.T) { ...@@ -456,26 +456,23 @@ func TestDependencies(t *testing.T) {
} }
sort.Strings(all) sort.Strings(all)
test := func(mustImport bool) { for _, pkg := range all {
for _, pkg := range all { imports, err := findImports(pkg)
imports, err := findImports(pkg) if err != nil {
if err != nil { t.Error(err)
t.Error(err) continue
continue }
} ok := allowed(pkg)
ok := allowed(pkg) var bad []string
var bad []string for _, imp := range imports {
for _, imp := range imports { if !ok[imp] {
if !ok[imp] { bad = append(bad, imp)
bad = append(bad, imp)
}
}
if bad != nil {
t.Errorf("unexpected dependency: %s imports %v", pkg, bad)
} }
} }
if bad != nil {
t.Errorf("unexpected dependency: %s imports %v", pkg, bad)
}
} }
test(true)
} }
var buildIgnore = []byte("\n// +build ignore") var buildIgnore = []byte("\n// +build ignore")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment