Commit 2277e8d3 authored by Mikio Hara's avatar Mikio Hara

net: disable TestDNSThreadLimit even in non-short mode by default

TestDNSThreadLimit creates tons of DNS queries and it occasionally
causes an unintentional traffic jam and/or crash of some virtual
machine software, especially its builtin networking stuff.

We can run TestDNSThreadLimit with -dnsflood flag instead.

LGTM=dave, rsc
R=rsc, dave
CC=golang-codereviews
https://golang.org/cl/63600043
parent 801e40a0
...@@ -5,13 +5,16 @@ ...@@ -5,13 +5,16 @@
package net package net
import ( import (
"flag"
"fmt" "fmt"
"testing" "testing"
) )
var testDNSFlood = flag.Bool("dnsflood", false, "whether to test dns query flooding")
func TestDNSThreadLimit(t *testing.T) { func TestDNSThreadLimit(t *testing.T) {
if testing.Short() || !*testExternal { if !*testDNSFlood {
t.Skip("skipping test to avoid external network") t.Skip("test disabled; use -dnsflood to enable")
} }
const N = 10000 const N = 10000
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment