Commit 279b530d authored by Russ Cox's avatar Russ Cox

cmd/go: respect vet typecheck failures again

Now that #18395 is fixed, let's see if we can insist
on vet during go test being able to type-check
packages again.

Change-Id: Iaa55a4d9c582ba743df2347d28c24f130e16e406
Reviewed-on: https://go-review.googlesource.com/108555
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
parent 1a64025f
...@@ -720,7 +720,9 @@ func (b *Builder) vet(a *Action) error { ...@@ -720,7 +720,9 @@ func (b *Builder) vet(a *Action) error {
// so at least for now assume the bug is in vet. // so at least for now assume the bug is in vet.
// We know of at least #18395. // We know of at least #18395.
// TODO(rsc,gri): Try to remove this for Go 1.11. // TODO(rsc,gri): Try to remove this for Go 1.11.
vcfg.SucceedOnTypecheckFailure = cfg.CmdName == "test" //
// Disabled 2018-04-20. Let's see if we can do without it.
// vcfg.SucceedOnTypecheckFailure = cfg.CmdName == "test"
js, err := json.MarshalIndent(vcfg, "", "\t") js, err := json.MarshalIndent(vcfg, "", "\t")
if err != nil { if err != nil {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment