Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
G
golang
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
golang
Commits
3108f3f4
Commit
3108f3f4
authored
Feb 09, 2011
by
Yasuhiro Matsumoto
Committed by
Russ Cox
Feb 09, 2011
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
codereview: use cmd.communicate.
R=golang-dev, rsc CC=golang-dev
https://golang.org/cl/4145046
parent
642c7740
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
4 deletions
+2
-4
codereview.py
lib/codereview/codereview.py
+2
-4
No files found.
lib/codereview/codereview.py
View file @
3108f3f4
...
...
@@ -1146,10 +1146,8 @@ def clpatch(ui, repo, clname, **opts):
except
:
return
"hgpatch: "
+
ExceptionDetail
()
cmd
.
stdin
.
write
(
patch
)
cmd
.
stdin
.
close
()
out
=
cmd
.
stdout
.
read
()
if
cmd
.
wait
()
!=
0
and
not
opts
[
"ignore_hgpatch_failure"
]:
out
,
err
=
cmd
.
communicate
(
patch
)
if
cmd
.
returncode
!=
0
and
not
opts
[
"ignore_hgpatch_failure"
]:
return
"hgpatch failed"
cl
.
local
=
True
cl
.
files
=
out
.
strip
()
.
split
()
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment