Commit 3185cfbf authored by Mikio Hara's avatar Mikio Hara

net: rename netFD.proto to netFD.net on Plan 9

In followup changes, we'll move OpError around from the netFD layer to
the Conn layer for fixing #4856. Before doing that, this change makes
netFD of Plan 9 match netFD for POSIX platforms to avoid conflict.

Change-Id: Iea7632716d48722a1758e52effefec964a3a9442
Reviewed-on: https://go-review.googlesource.com/8990Reviewed-by: 's avatarDavid du Colombier <0intro@gmail.com>
Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 28388c4e
...@@ -17,7 +17,7 @@ type netFD struct { ...@@ -17,7 +17,7 @@ type netFD struct {
fdmu fdMutex fdmu fdMutex
// immutable until Close // immutable until Close
proto string net string
n string n string
dir string dir string
ctl, data *os.File ctl, data *os.File
...@@ -38,8 +38,8 @@ func dial(net string, ra Addr, dialer func(time.Time) (Conn, error), deadline ti ...@@ -38,8 +38,8 @@ func dial(net string, ra Addr, dialer func(time.Time) (Conn, error), deadline ti
return dialChannel(net, ra, dialer, deadline) return dialChannel(net, ra, dialer, deadline)
} }
func newFD(proto, name string, ctl, data *os.File, laddr, raddr Addr) (*netFD, error) { func newFD(net, name string, ctl, data *os.File, laddr, raddr Addr) (*netFD, error) {
return &netFD{proto: proto, n: name, dir: netdir + "/" + proto + "/" + name, ctl: ctl, data: data, laddr: laddr, raddr: raddr}, nil return &netFD{net: net, n: name, dir: netdir + "/" + net + "/" + name, ctl: ctl, data: data, laddr: laddr, raddr: raddr}, nil
} }
func (fd *netFD) init() error { func (fd *netFD) init() error {
...@@ -55,7 +55,7 @@ func (fd *netFD) name() string { ...@@ -55,7 +55,7 @@ func (fd *netFD) name() string {
if fd.raddr != nil { if fd.raddr != nil {
rs = fd.raddr.String() rs = fd.raddr.String()
} }
return fd.proto + ":" + ls + "->" + rs return fd.net + ":" + ls + "->" + rs
} }
func (fd *netFD) ok() bool { return fd != nil && fd.ctl != nil } func (fd *netFD) ok() bool { return fd != nil && fd.ctl != nil }
...@@ -132,7 +132,7 @@ func (fd *netFD) Read(b []byte) (n int, err error) { ...@@ -132,7 +132,7 @@ func (fd *netFD) Read(b []byte) (n int, err error) {
} }
defer fd.readUnlock() defer fd.readUnlock()
n, err = fd.data.Read(b) n, err = fd.data.Read(b)
if fd.proto == "udp" && err == io.EOF { if fd.net == "udp" && err == io.EOF {
n = 0 n = 0
err = nil err = nil
} }
......
...@@ -193,7 +193,7 @@ func listenPlan9(net string, laddr Addr) (fd *netFD, err error) { ...@@ -193,7 +193,7 @@ func listenPlan9(net string, laddr Addr) (fd *netFD, err error) {
} }
func (l *netFD) netFD() (*netFD, error) { func (l *netFD) netFD() (*netFD, error) {
return newFD(l.proto, l.n, l.ctl, l.data, l.laddr, l.raddr) return newFD(l.net, l.n, l.ctl, l.data, l.laddr, l.raddr)
} }
func (l *netFD) acceptPlan9() (fd *netFD, err error) { func (l *netFD) acceptPlan9() (fd *netFD, err error) {
...@@ -213,16 +213,16 @@ func (l *netFD) acceptPlan9() (fd *netFD, err error) { ...@@ -213,16 +213,16 @@ func (l *netFD) acceptPlan9() (fd *netFD, err error) {
return nil, &OpError{"accept", l.dir + "/listen", l.laddr, err} return nil, &OpError{"accept", l.dir + "/listen", l.laddr, err}
} }
name := string(buf[:n]) name := string(buf[:n])
data, err := os.OpenFile(netdir+"/"+l.proto+"/"+name+"/data", os.O_RDWR, 0) data, err := os.OpenFile(netdir+"/"+l.net+"/"+name+"/data", os.O_RDWR, 0)
if err != nil { if err != nil {
f.Close() f.Close()
return nil, &OpError{"accept", l.proto, l.laddr, err} return nil, &OpError{"accept", l.net, l.laddr, err}
} }
raddr, err := readPlan9Addr(l.proto, netdir+"/"+l.proto+"/"+name+"/remote") raddr, err := readPlan9Addr(l.net, netdir+"/"+l.net+"/"+name+"/remote")
if err != nil { if err != nil {
data.Close() data.Close()
f.Close() f.Close()
return nil, &OpError{"accept", l.proto, l.laddr, err} return nil, &OpError{"accept", l.net, l.laddr, err}
} }
return newFD(l.proto, name, f, data, l.laddr, raddr) return newFD(l.net, name, f, data, l.laddr, raddr)
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment