Commit 3185f862 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick

net/textproto: turn an ancient DoS BUG annotation into a comment

Actually fixing this "bug" would be weird, since io.LimitReader already
does what we need, as demonstrated by net/http's use.

Thanks to @davidfstr for pointing this out.

Change-Id: If707bcc698d1666a369b39ddfa9770685fbe3879
Reviewed-on: https://go-review.googlesource.com/1579Reviewed-by: 's avatarRob Pike <r@golang.org>
parent df1739c7
...@@ -13,10 +13,6 @@ import ( ...@@ -13,10 +13,6 @@ import (
"strings" "strings"
) )
// BUG(rsc): To let callers manage exposure to denial of service
// attacks, Reader should allow them to set and reset a limit on
// the number of bytes read from the connection.
// A Reader implements convenience methods for reading requests // A Reader implements convenience methods for reading requests
// or responses from a text protocol network connection. // or responses from a text protocol network connection.
type Reader struct { type Reader struct {
...@@ -26,6 +22,10 @@ type Reader struct { ...@@ -26,6 +22,10 @@ type Reader struct {
} }
// NewReader returns a new Reader reading from r. // NewReader returns a new Reader reading from r.
//
// To avoid denial of service attacks, the provided bufio.Reader
// should be reading from an io.LimitReader or similar Reader to bound
// the size of responses.
func NewReader(r *bufio.Reader) *Reader { func NewReader(r *bufio.Reader) *Reader {
return &Reader{R: r} return &Reader{R: r}
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment