Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
G
golang
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
golang
Commits
34139ee1
Commit
34139ee1
authored
Dec 22, 2011
by
Rob Pike
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
testing: fix wording in explanation of potential bug
TBR=rsc R=rsc CC=golang-dev
https://golang.org/cl/5504075
parent
66155134
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
testing.go
src/pkg/testing/testing.go
+3
-3
No files found.
src/pkg/testing/testing.go
View file @
34139ee1
...
...
@@ -240,9 +240,9 @@ func RunTests(matchString func(pat, str string) (bool, error), tests []InternalT
runtime
.
GOMAXPROCS
(
procs
)
// We build a new channel tree for each run of the loop.
// collector merges in one channel all the upstream signals from parallel tests.
// If all tests pump to the same channel, a bug can occur where a
goroutine
// kicks off a
test, fails, and still delivers a completion signal, which skews the
// counting.
// If all tests pump to the same channel, a bug can occur where a
test
// kicks off a
gouroutine that Fails, yet the test still delivers a completion signal,
//
which skews the
counting.
var
collector
=
make
(
chan
interface
{})
numParallel
:=
0
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment