Commit 4766a35e authored by Dave Cheney's avatar Dave Cheney

net: TestDialTimeoutFDLeak failure

Fixes #4384.

Implments the suggestion by rsc in comment 15, http://code.google.com/p/go/issues/detail?id=4384#c15

An alternate suggestion would be to temporarily set GOMAXPROCS to 1 during this test.

R=fullung, rsc
CC=golang-dev
https://golang.org/cl/6923046
parent c3d881b3
...@@ -240,7 +240,8 @@ func TestDialTimeoutFDLeak(t *testing.T) { ...@@ -240,7 +240,8 @@ func TestDialTimeoutFDLeak(t *testing.T) {
err error err error
} }
dials := listenerBacklog + 100 dials := listenerBacklog + 100
maxGoodConnect := listenerBacklog + 5 // empirically 131 good ones (of 128). who knows? // used to be listenerBacklog + 5, but was found to be unreliable, issue 4384.
maxGoodConnect := 150
resc := make(chan connErr) resc := make(chan connErr)
for i := 0; i < dials; i++ { for i := 0; i < dials; i++ {
go func() { go func() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment