html: on EOF in a comment, ignore final dashes (up to 2)

Pass tests2.dat, test 57: <!DOCTYPE html> | <html> | <head> | <body> Also pass test 58: <!DOCTYPE html><table><tr><td></p></table> R=nigeltao CC=golang-dev https://golang.org/cl/5436048

html: on EOF in a comment, ignore final dashes (up to 2)
57ed39fd · Andrew Balholm · Nigel Tao · 79bce499 · 57ed39fd · 57ed39fd
Commit 57ed39fd authored Nov 22, 2011 by Andrew Balholm Committed by Nigel Tao Nov 22, 2011
Hide whitespace changes
Inline Side-by-side

Showing with 26 additions and 2 deletions

parse_test.go src/pkg/html/parse_test.go +1 -1

token.go src/pkg/html/token.go +5 -1

token_test.go src/pkg/html/token_test.go +20 -0

No files found.
--- a/src/pkg/html/parse_test.go
+++ b/src/pkg/html/parse_test.go
@@ -134,7 +134,7 @@ func TestParser(t *testing.T) {
 	}{
 		// TODO(nigeltao): Process all the test cases from all the .dat files.
 		{"tests1.dat", -1},
-		{"tests2.dat", 57},
+		{"tests2.dat", 59},
 		{"tests3.dat", 0},
 	}
 	for _, tf := range testFiles {

--- a/src/pkg/html/token.go
+++ b/src/pkg/html/token.go
@@ -289,7 +289,11 @@ func (z *Tokenizer) readComment() {
 	for dashCount := 2; ; {
 		c := z.readByte()
 		if z.err != nil {
-			z.data.end = z.raw.end
+			// Ignore up to two dashes at EOF.
+			if dashCount > 2 {
+				dashCount = 2
+			}
+			z.data.end = z.raw.end - dashCount
 			return
 		}
 		switch c {

--- a/src/pkg/html/token_test.go
+++ b/src/pkg/html/token_test.go
@@ -325,6 +325,26 @@ var tokenTests = []tokenTest{
 	},
 	{
 		"comment9",
+		"a<!--z-",
+		"a$<!--z-->",
+	},
+	{
+		"comment10",
+		"a<!--z--",
+		"a$<!--z-->",
+	},
+	{
+		"comment11",
+		"a<!--z---",
+		"a$<!--z--->",
+	},
+	{
+		"comment12",
+		"a<!--z----",
+		"a$<!--z---->",
+	},
+	{
+		"comment13",
 		"a<!--x--!>z",
 		"a$<!--x-->$z",
 	},