Commit 7c0db1b7 authored by Didier Spezia's avatar Didier Spezia Committed by Ian Lance Taylor

cmd/gc: do not display ~b identifiers in error messages

Instead of errors like:

./blank2.go:15: cannot use ~b1 (type []int) as type int in assignment

we now have:

./blank2.go:15: cannot use _ (type []int) as type int in assignment

Less confusing for users.

Fixes #9521

Change-Id: Ieab9859040e8e0df95deeaee7eeb408d3be61c0f
Reviewed-on: https://go-review.googlesource.com/9902Reviewed-by: 's avatarJosh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
parent 3475ec7f
...@@ -1127,7 +1127,7 @@ func exprfmt(n *Node, prec int) string { ...@@ -1127,7 +1127,7 @@ func exprfmt(n *Node, prec int) string {
// Special case: name used as local variable in export. // Special case: name used as local variable in export.
// _ becomes ~b%d internally; print as _ for export // _ becomes ~b%d internally; print as _ for export
case ONAME: case ONAME:
if fmtmode == FExp && n.Sym != nil && n.Sym.Name[0] == '~' && n.Sym.Name[1] == 'b' { if (fmtmode == FExp || fmtmode == FErr) && n.Sym != nil && n.Sym.Name[0] == '~' && n.Sym.Name[1] == 'b' {
return "_" return "_"
} }
if fmtmode == FExp && n.Sym != nil && !isblank(n) && n.Vargen > 0 { if fmtmode == FExp && n.Sym != nil && !isblank(n) && n.Vargen > 0 {
......
// errorcheck
// Copyright 2015 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Test that an incorrect use of the blank identifer is caught.
// Does not compile.
package main
func f() (_, _ []int) { return }
func main() {
_ = append(f()) // ERROR "cannot use _"
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment