Commit 7cddd39f authored by Russ Cox's avatar Russ Cox

cmd/go: drop flaky part of TestGoTestJSON

Still failing on builders. I give up.
(For example https://build.golang.org/log/4fa5ba031c2fab5df397ac894f8b81392a93728e.)

Change-Id: Ifa87813e27e1adfe9920c7e657b0ff129eb5bf2f
Reviewed-on: https://go-review.googlesource.com/78315Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
parent 8e28a8d2
...@@ -5173,44 +5173,14 @@ func TestGoTestJSON(t *testing.T) { ...@@ -5173,44 +5173,14 @@ func TestGoTestJSON(t *testing.T) {
tg.setenv("GOCACHE", tg.tempdir) tg.setenv("GOCACHE", tg.tempdir)
tg.setenv("GOPATH", filepath.Join(tg.pwd(), "testdata")) tg.setenv("GOPATH", filepath.Join(tg.pwd(), "testdata"))
// Test that math and fmt output is interlaced. // It would be nice to test that the output is interlaced
// This has the potential to be a flaky test, // but it seems to be impossible to do that in a short test
// especially on uniprocessor systems, so only // that isn't also flaky. Just check that we get JSON output.
// require interlacing if we have at least 4 CPUs. tg.run("test", "-json", "-short", "-v", "errors")
// We also try twice, hoping that the cache will be for _, line := range strings.Split(tg.getStdout(), "\n") {
// warmed up the second time. if strings.Contains(line, `"Package":"errors"`) {
needInterlace := runtime.GOMAXPROCS(-1) >= 4 return
for try := 0; ; try++ {
tg.run("test", "-json", "-short", "-v", "sleepy1", "sleepy2")
sawSleepy1 := false
sawSleepy2 := false
state := 0
for _, line := range strings.Split(tg.getStdout(), "\n") {
if strings.Contains(line, `"Package":"sleepy1"`) {
sawSleepy1 = true
if state == 0 {
state = 1
}
if state == 2 {
state = 3
}
}
if strings.Contains(line, `"Package":"sleepy2"`) {
sawSleepy2 = true
if state == 1 {
state = 2
}
}
}
if !sawSleepy1 || !sawSleepy2 {
t.Fatalf("did not see output from both sleepy1 and sleepy2")
}
if needInterlace && state != 3 {
if try < 1 {
continue
}
t.Fatalf("did not find sleepy1 interlaced with sleepy2")
} }
break
} }
t.Fatalf("did not see JSON output")
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment