Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
G
golang
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
golang
Commits
844ec6bb
Commit
844ec6bb
authored
Apr 06, 2014
by
Russ Cox
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
cmd/8g: fix liveness for 387 build (including plan9)
TBR=khr CC=golang-codereviews
https://golang.org/cl/84570045
parent
258ee61c
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
6 deletions
+19
-6
prog.c
src/cmd/8g/prog.c
+10
-5
plive.c
src/cmd/gc/plive.c
+9
-1
No files found.
src/cmd/8g/prog.c
View file @
844ec6bb
...
...
@@ -138,11 +138,16 @@ static ProgInfo progtable[ALAST] = {
[
AFMOVW
]
=
{
SizeW
|
LeftAddr
|
RightWrite
},
[
AFMOVV
]
=
{
SizeQ
|
LeftAddr
|
RightWrite
},
[
AFMOVDP
]
=
{
SizeD
|
LeftRead
|
RightAddr
},
[
AFMOVFP
]
=
{
SizeF
|
LeftRead
|
RightAddr
},
[
AFMOVLP
]
=
{
SizeL
|
LeftRead
|
RightAddr
},
[
AFMOVWP
]
=
{
SizeW
|
LeftRead
|
RightAddr
},
[
AFMOVVP
]
=
{
SizeQ
|
LeftRead
|
RightAddr
},
// These instructions are marked as RightAddr
// so that the register optimizer does not try to replace the
// memory references with integer register references.
// But they do not use the previous value at the address, so
// we also mark them RightWrite.
[
AFMOVDP
]
=
{
SizeD
|
LeftRead
|
RightWrite
|
RightAddr
},
[
AFMOVFP
]
=
{
SizeF
|
LeftRead
|
RightWrite
|
RightAddr
},
[
AFMOVLP
]
=
{
SizeL
|
LeftRead
|
RightWrite
|
RightAddr
},
[
AFMOVWP
]
=
{
SizeW
|
LeftRead
|
RightWrite
|
RightAddr
},
[
AFMOVVP
]
=
{
SizeQ
|
LeftRead
|
RightWrite
|
RightAddr
},
[
AFMULD
]
=
{
SizeD
|
LeftAddr
|
RightRdwr
},
[
AFMULDP
]
=
{
SizeD
|
LeftAddr
|
RightRdwr
},
...
...
src/cmd/gc/plive.c
View file @
844ec6bb
...
...
@@ -755,7 +755,15 @@ Next:
if
(
prog
->
as
==
AVARDEF
||
prog
->
as
==
AVARKILL
)
bvset
(
varkill
,
pos
);
}
else
{
if
(
info
.
flags
&
(
RightRead
|
RightAddr
))
// RightRead is a read, obviously.
// RightAddr by itself is also implicitly a read.
//
// RightAddr|RightWrite means that the address is being taken
// but only so that the instruction can write to the value.
// It is not a read. It is equivalent to RightWrite except that
// having the RightAddr bit set keeps the registerizer from
// trying to substitute a register for the memory location.
if
((
info
.
flags
&
RightRead
)
||
(
info
.
flags
&
(
RightAddr
|
RightWrite
))
==
RightAddr
)
bvset
(
uevar
,
pos
);
if
(
info
.
flags
&
RightWrite
)
if
(
to
->
node
!=
nil
&&
(
!
isfat
(
to
->
node
->
type
)
||
prog
->
as
==
AVARDEF
))
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment