Commit 951318c0 authored by Russ Cox's avatar Russ Cox

runtime: remove paranoid mapping at 0

Too many programs complain that we even try.
This was a bit of security paranoia and not worth
the bother.

Fixes #1340.

R=r, r2
CC=golang-dev
https://golang.org/cl/3579042
parent 2ef09148
...@@ -36,11 +36,4 @@ runtime·SysFree(void *v, uintptr n) ...@@ -36,11 +36,4 @@ runtime·SysFree(void *v, uintptr n)
void void
runtime·SysMemInit(void) runtime·SysMemInit(void)
{ {
// Code generators assume that references to addresses
// on the first page will fault. Map the page explicitly with
// no permissions, to head off possible bugs like the system
// allocating that page as the virtual address space fills.
// Ignore any error, since other systems might be smart
// enough to never allow anything there.
// mmap(nil, 4096, PROT_NONE, MAP_FIXED|MAP_ANON|MAP_PRIVATE, -1, 0);
} }
...@@ -36,11 +36,4 @@ runtime·SysFree(void *v, uintptr n) ...@@ -36,11 +36,4 @@ runtime·SysFree(void *v, uintptr n)
void void
runtime·SysMemInit(void) runtime·SysMemInit(void)
{ {
// Code generators assume that references to addresses
// on the first page will fault. Map the page explicitly with
// no permissions, to head off possible bugs like the system
// allocating that page as the virtual address space fills.
// Ignore any error, since other systems might be smart
// enough to never allow anything there.
runtime·mmap(nil, 4096, PROT_NONE, MAP_FIXED|MAP_ANON|MAP_PRIVATE, -1, 0);
} }
...@@ -40,11 +40,4 @@ runtime·SysFree(void *v, uintptr n) ...@@ -40,11 +40,4 @@ runtime·SysFree(void *v, uintptr n)
void void
runtime·SysMemInit(void) runtime·SysMemInit(void)
{ {
// Code generators assume that references to addresses
// on the first page will fault. Map the page explicitly with
// no permissions, to head off possible bugs like the system
// allocating that page as the virtual address space fills.
// Ignore any error, since other systems might be smart
// enough to never allow anything there.
runtime·mmap(nil, 4096, PROT_NONE, MAP_FIXED|MAP_ANON|MAP_PRIVATE, -1, 0);
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment