Commit 95e6a9fc authored by Hana Kim's avatar Hana Kim Committed by Hyang-Ah Hana Kim

cmd/trace: pprof computation for span types

/spanio, /spanblock, /spansched, /spansyscall provide
the pprof-style summary of span execution's
io, block, scheduling, syscall latency distributions
respectively.

The computation logic for /io, /block, /sched, /syscall
analysis was refactored and extended for reuse in these
new types of analysis. Upon the analysis query, we create
a map of goroutine id to time intervals based on the query
parameter, that represents the interesting time intervals
of matching goroutines. Only the events from the matching
goroutines that fall into the intervals are considered
in the pprof computation.

The new endpoints are not yet hooked into other span
analysis page (e.g. /userspan) yet.

Change-Id: I80c3396e45a2d6631758710de67d132e5832c7ce
Reviewed-on: https://go-review.googlesource.com/105822Reviewed-by: 's avatarHeschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent 8bb8eaff
......@@ -83,19 +83,19 @@ func main() {
flag.Usage()
}
var pprofFunc func(io.Writer, string) error
var pprofFunc func(io.Writer, *http.Request) error
switch *pprofFlag {
case "net":
pprofFunc = pprofIO
pprofFunc = pprofByGoroutine(computePprofIO)
case "sync":
pprofFunc = pprofBlock
pprofFunc = pprofByGoroutine(computePprofBlock)
case "syscall":
pprofFunc = pprofSyscall
pprofFunc = pprofByGoroutine(computePprofSyscall)
case "sched":
pprofFunc = pprofSched
pprofFunc = pprofByGoroutine(computePprofSched)
}
if pprofFunc != nil {
if err := pprofFunc(os.Stdout, ""); err != nil {
if err := pprofFunc(os.Stdout, &http.Request{}); err != nil {
dief("failed to generate pprof: %v\n", err)
}
os.Exit(0)
......
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment