Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
G
golang
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
golang
Commits
96ee38bf
Commit
96ee38bf
authored
Dec 17, 2009
by
Rob Pike
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make it more explicit that design discussions should happen before code reviews
R=rsc CC=golang-dev
https://golang.org/cl/180075
parent
59a3cae4
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
26 additions
and
2 deletions
+26
-2
code.html
doc/code.html
+3
-2
contribute.html
doc/contribute.html
+23
-0
No files found.
doc/code.html
View file @
96ee38bf
...
@@ -12,10 +12,11 @@ It assumes you have installed Go using the
...
@@ -12,10 +12,11 @@ It assumes you have installed Go using the
<p>
<p>
Before embarking on a change to an existing
Before embarking on a change to an existing
package or the creation of a new package,
package or the creation of a new package,
it's a good idea to send mail to the
<a
href=
"http://groups.google.com/group/golang-nuts"
>
mailing list
</a>
be sure to send mail to the
<a
href=
"http://groups.google.com/group/golang-nuts"
>
mailing list
</a>
to let people know what you are thinking of doing.
to let people know what you are thinking of doing.
Doing so helps avoid duplication of effort and
Doing so helps avoid duplication of effort and
enables discussions about design before
much
code
enables discussions about design before
any
code
has been written.
has been written.
</p>
</p>
...
...
doc/contribute.html
View file @
96ee38bf
...
@@ -11,6 +11,29 @@ have <a href="code.html">written and tested your code</a>.
...
@@ -11,6 +11,29 @@ have <a href="code.html">written and tested your code</a>.
see
<a
href=
"gccgo_contribute.html"
>
Contributing to gccgo
</a>
.)
see
<a
href=
"gccgo_contribute.html"
>
Contributing to gccgo
</a>
.)
</p>
</p>
<h2
id=
"Design"
>
Discuss your design
</h2>
<p>
The project welcomes submissions but please let everyone know what
you're working on if you want it to become part of the main repository.
</p>
<p>
Before undertaking to write something new for the Go project, send
mail to the
<a
href=
"http://groups.google.com/group/golang-nuts"
>
mailing
list
</a>
to discuss what you plan to do. This gives everyone a
chance to validate the design, helps prevent duplication of effort,
and ensures that the idea fits inside the goals for the language
and tools. It also guarantees that the design is sound before code
is written; the code review tool is not the place for high-level
discussions.
</p>
<p>
In short, send mail before you code.
And don't start the discussion by mailing a change list!
</p>
<h2
id=
"Testing"
>
Testing redux
</h2>
<h2
id=
"Testing"
>
Testing redux
</h2>
<p>
<p>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment