Commit 9f408427 authored by Rob Pike's avatar Rob Pike

fmt: fix internal unknownType function

This thing should never be called, but before
151960044 it was being called, incorrectly.
This is now just a precaution but let's pretend it
Fixes #8843
even though that was fixed by 151960044.
The test case was already there and ran, another mystery.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/151970043
parent 62d3202a
......@@ -297,13 +297,13 @@ func parsenum(s string, start, end int) (num int, isnum bool, newi int) {
return
}
func (p *pp) unknownType(v interface{}) {
if v == nil {
func (p *pp) unknownType(v reflect.Value) {
if !v.IsValid() {
p.buf.Write(nilAngleBytes)
return
}
p.buf.WriteByte('?')
p.buf.WriteString(reflect.TypeOf(v).String())
p.buf.WriteString(v.Type().String())
p.buf.WriteByte('?')
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment