Commit a9d0244c authored by Martin Möhrmann's avatar Martin Möhrmann Committed by Rob Pike

fmt: replace variables for type bit sizes with constants

Use constants instead of dynamically computed values to determine
the bit sizes of types similar to how strconv and other packages
directly compute these sizes. Move these constants near the code
that uses them.

Change-Id: I78d113b7e697466097e32653975df5990380c2c1
Reviewed-on: https://go-review.googlesource.com/20514
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: 's avatarRob Pike <r@golang.org>
parent 5630cb75
...@@ -578,11 +578,6 @@ func (p *pp) fmtPointer(value reflect.Value, verb rune) { ...@@ -578,11 +578,6 @@ func (p *pp) fmtPointer(value reflect.Value, verb rune) {
} }
} }
var (
intBits = reflect.TypeOf(0).Bits()
uintptrBits = reflect.TypeOf(uintptr(0)).Bits()
)
func (p *pp) catchPanic(arg interface{}, verb rune) { func (p *pp) catchPanic(arg interface{}, verb rune) {
if err := recover(); err != nil { if err := recover(); err != nil {
// If it's a nil pointer, just say "<nil>". The likeliest causes are a // If it's a nil pointer, just say "<nil>". The likeliest causes are a
......
...@@ -915,9 +915,14 @@ func (s *ss) hexString() string { ...@@ -915,9 +915,14 @@ func (s *ss) hexString() string {
return string(s.buf) return string(s.buf)
} }
const floatVerbs = "beEfFgGv" const (
floatVerbs = "beEfFgGv"
hugeWid = 1 << 30
const hugeWid = 1 << 30 intBits = 32 << (^uint(0) >> 63)
uintptrBits = 32 << (^uintptr(0) >> 63)
)
// scanOne scans a single value, deriving the scanner from the type of the argument. // scanOne scans a single value, deriving the scanner from the type of the argument.
func (s *ss) scanOne(verb rune, arg interface{}) { func (s *ss) scanOne(verb rune, arg interface{}) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment