Commit ad87a67c authored by Elias Naur's avatar Elias Naur

cmd/dist: default to GOARM=7 on android

Auto-detecting GOARM on Android makes as little sense as for nacl/arm
and darwin/arm.

Also update androidtest.sh to not require GOARM set.

Change-Id: Id409ce1573d3c668d00fa4b7e3562ad7ece6fef5
Reviewed-on: https://go-review.googlesource.com/98875Reviewed-by: 's avatarHyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent 084143d8
...@@ -23,10 +23,7 @@ if [ "$GOOS" != "android" ]; then ...@@ -23,10 +23,7 @@ if [ "$GOOS" != "android" ]; then
exit 1 exit 1
fi fi
if [ -z $GOARM ]; then if [ -n "$GOARM" ] && [ "$GOARM" != "7" ]; then
export GOARM=7
fi
if [ "$GOARM" != "7" ]; then
echo "android only supports GOARM=7, got GOARM=$GOARM" 1>&2 echo "android only supports GOARM=7, got GOARM=$GOARM" 1>&2
exit 1 exit 1
fi fi
......
...@@ -387,9 +387,9 @@ func xgetgoarm() string { ...@@ -387,9 +387,9 @@ func xgetgoarm() string {
// NaCl guarantees VFPv3 and is always cross-compiled. // NaCl guarantees VFPv3 and is always cross-compiled.
return "7" return "7"
} }
if goos == "darwin" { if goos == "darwin" || goos == "android" {
// Assume all darwin/arm devices are have VFPv3. This // Assume all darwin/arm and android devices have VFPv3.
// port is also mostly cross-compiled, so it makes little // These ports are also mostly cross-compiled, so it makes little
// sense to auto-detect the setting. // sense to auto-detect the setting.
return "7" return "7"
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment