Commit b506c3e1 authored by David Symonds's avatar David Symonds

misc/dashboard/codereview: only accept "NOT LGTM" on the first line of a message.

Too many people quote entire emails and put their reply at the top ("top posting"),
so we shouldn't recognise review commands anywhere in the review text.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6815048
parent ee3e2ac1
......@@ -389,7 +389,7 @@ func updateCL(c appengine.Context, n string) error {
lgtm[s] = true
delete(notLGTM, s) // "LGTM" overrules previous "NOT LGTM"
}
if strings.Contains(msg.Text, "NOT LGTM") {
if strings.Contains(line, "NOT LGTM") {
notLGTM[s] = true
delete(lgtm, s) // "NOT LGTM" overrules previous "LGTM"
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment