html/template: make doctype check case-insensitive

Fixes #3094. R=golang-dev, rsc, nigeltao CC=golang-dev https://golang.org/cl/5687065

html/template: make doctype check case-insensitive
Fixes #3094. R=golang-dev, rsc, nigeltao CC=golang-dev https://golang.org/cl/5687065
c05c3a9d · Scott Lawrence · Nigel Tao · 19bab1dc · c05c3a9d · c05c3a9d
Commit c05c3a9d authored Feb 24, 2012 by Scott Lawrence Committed by Nigel Tao Feb 24, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

escape.go src/pkg/html/template/escape.go +1 -1

escape_test.go src/pkg/html/template/escape_test.go +5 -0

No files found.
--- a/src/pkg/html/template/escape.go
+++ b/src/pkg/html/template/escape.go
@@ -593,7 +593,7 @@ func (e *escaper) escapeText(c context, n *parse.TextNode) context {
 				}
 			}
 			for j := i; j < end; j++ {
-				if s[j] == '<' && !bytes.HasPrefix(s[j:], doctypeBytes) {
+				if s[j] == '<' && !bytes.HasPrefix(bytes.ToUpper(s[j:]), doctypeBytes) {
 					b.Write(s[written:j])
 					b.WriteString("&lt;")
 					written = j + 1

--- a/src/pkg/html/template/escape_test.go
+++ b/src/pkg/html/template/escape_test.go
@@ -431,6 +431,11 @@ func TestEscape(t *testing.T) {
 			"<!DOCTYPE html>Hello, World!",
 			"<!DOCTYPE html>Hello, World!",
 		},
+		{
+			"HTML doctype not case-insensitive",
+			"<!doCtYPE htMl>Hello, World!",
+			"<!doCtYPE htMl>Hello, World!",
+		},
 		{
 			"No doctype injection",
 			`<!{{"DOCTYPE"}}`,