Commit d81cc374 authored by Rahul Chaudhry's avatar Rahul Chaudhry Committed by Ian Lance Taylor

test: chdir before running go tool, cleanup afterwards.

issue9355 generated a file a.[568] in test/ directory and left it there.
For tests like these, it is best to chdir to a test specific directory
before generating any temporary files, since the tests are running
in parallel and might otherwise race with each other for the same files.

Change-Id: I58d96256d4d8ee3fda70d81077f19006064a7425
Reviewed-on: https://go-review.googlesource.com/3813Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
parent f5f00be2
...@@ -21,11 +21,14 @@ func main() { ...@@ -21,11 +21,14 @@ func main() {
return return
} }
a, err := build.ArchChar(runtime.GOARCH) a, err := build.ArchChar(runtime.GOARCH)
if err != nil { check(err)
fmt.Println("BUG:", err)
os.Exit(1) err = os.Chdir(filepath.Join("fixedbugs", "issue9355.dir"))
} check(err)
out := run("go", "tool", a+"g", "-S", filepath.Join("fixedbugs", "issue9355.dir", "a.go"))
out := run("go", "tool", a+"g", "-S", "a.go")
os.Remove("a." + a)
// 6g/8g print the offset as dec, but 5g/9g print the offset as hex. // 6g/8g print the offset as dec, but 5g/9g print the offset as hex.
patterns := []string{ patterns := []string{
`rel 0\+\d t=1 \"\"\.x\+8\r?\n`, // y = &x.b `rel 0\+\d t=1 \"\"\.x\+8\r?\n`, // y = &x.b
...@@ -50,3 +53,10 @@ func run(cmd string, args ...string) []byte { ...@@ -50,3 +53,10 @@ func run(cmd string, args ...string) []byte {
} }
return out return out
} }
func check(err error) {
if err != nil {
fmt.Println("BUG:", err)
os.Exit(1)
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment