Commit e87af8c4 authored by David Symonds's avatar David Symonds

misc/dashboard: don't update tip tag for release branch commits.

This will mean that sub-repositories won't get built against the
release branch. They are often not compatible because the subrepos
often run ahead of the current release (e.g. go.tools is using
new additions to go/ast, and go.net is using new things in syscall)
so there's little point in checking them against cherrypick commits
when they'll be tested against those commits on tip anyway.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/12001043
parent b7c3d06a
...@@ -11,6 +11,7 @@ import ( ...@@ -11,6 +11,7 @@ import (
"errors" "errors"
"fmt" "fmt"
"net/http" "net/http"
"strings"
"appengine" "appengine"
"appengine/datastore" "appengine/datastore"
...@@ -98,8 +99,8 @@ func addCommit(c appengine.Context, com *Commit) error { ...@@ -98,8 +99,8 @@ func addCommit(c appengine.Context, com *Commit) error {
return errors.New("parent commit not found") return errors.New("parent commit not found")
} }
} }
// update the tip Tag if this is the Go repo // update the tip Tag if this is the Go repo and this isn't on a release branch
if p.Path == "" { if p.Path == "" && !strings.HasPrefix(com.Desc, "[release-branch") {
t := &Tag{Kind: "tip", Hash: com.Hash} t := &Tag{Kind: "tip", Hash: com.Hash}
if _, err = datastore.Put(c, t.Key(c), t); err != nil { if _, err = datastore.Put(c, t.Key(c), t); err != nil {
return fmt.Errorf("putting Tag: %v", err) return fmt.Errorf("putting Tag: %v", err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment