Commit f8dc4f20 authored by Josh Bleecher Snyder's avatar Josh Bleecher Snyder Committed by Brad Fitzpatrick

Revert "cmd/vet: ignore printf failures in cmd"

This reverts commit f15915af.

CL 32851 fixed cmd/vet's handling of fmt.Formatter.

Updates #17057.

Change-Id: I3409100d16037645946fe7fe78fbb173e1648494
Reviewed-on: https://go-review.googlesource.com/33166
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 7c9f9106
......@@ -265,15 +265,6 @@ NextLine:
}
}
// Temporarily ignore unrecognized printf verbs from cmd.
// The compiler now has several fancy verbs (CL 28339)
// used with types implementing fmt.Formatters,
// and I believe gri has plans to add many more.
// TODO: remove when issue 17057 is fixed.
if strings.HasPrefix(file, "cmd/") && strings.HasPrefix(msg, "unrecognized printf verb") {
continue
}
key := file + ": " + msg
if w[key] == 0 {
// Vet error with no match in the whitelist. Print it.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment