Commit fa62ea69 authored by Russ Cox's avatar Russ Cox

cmd/dist: do not reinstall runtime/cgo with -tags lldb on ios builders

The cache will take care of keeping go test -tags lldb fast.
Installing runtime/cgo this way just makes all the checkNotStale
tests think runtime/cgo is out of date.

Should fix ios builders.

Fixes #22509.

Change-Id: If092cc4feb189eb848b6a22f6d22b89b70df219c
Reviewed-on: https://go-review.googlesource.com/76020
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: 's avatarDavid Crawshaw <crawshaw@golang.org>
parent 1ca4768e
......@@ -139,29 +139,6 @@ func (t *tester) run() {
checkNotStale("go", "std", "cmd")
}
if t.iOS() {
// Install the Mach exception handler used to intercept
// EXC_BAD_ACCESS and convert it into a Go panic. This is
// necessary for a Go program running under lldb (the way
// we run tests). It is disabled by default because iOS
// apps are not allowed to access the exc_server symbol.
cmd := exec.Command("go", "install", "-a", "-tags", "lldb", "runtime/cgo")
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
if err := cmd.Run(); err != nil {
log.Fatalf("building mach exception handler: %v", err)
}
defer func() {
cmd := exec.Command("go", "install", "-a", "runtime/cgo")
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
if err := cmd.Run(); err != nil {
log.Fatalf("reverting mach exception handler: %v", err)
}
}()
}
t.timeoutScale = 1
switch goarch {
case "arm":
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment