1. 29 Nov, 2016 15 commits
    • Brad Fitzpatrick's avatar
      doc: more additions to go1.8.html · 00047248
      Brad Fitzpatrick authored
      Adds crypto/tls, crypto/x509, math/big, mime.
      
      TBR=See https://golang.org/cl/33244
      
      Updates #17929
      
      Change-Id: I3fa3739e56f8c005e2a43c19f525cc5e2d981935
      Reviewed-on: https://go-review.googlesource.com/33666Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      00047248
    • Brad Fitzpatrick's avatar
      doc: more go1.8.html tweaks and new context additions section · 268bc396
      Brad Fitzpatrick authored
      TBR=See https://golang.org/cl/33244
      
      Updates #17929
      
      Change-Id: Id5d5472cf1e41472d8d0f82ee133c7387257ba2b
      Reviewed-on: https://go-review.googlesource.com/33664Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      268bc396
    • Robert Griesemer's avatar
      cmd/compile/internal/syntax: remove unused node field · 11f8676b
      Robert Griesemer authored
      The doc field is not yet used - remove it for now (we may end up
      with a different solution for 1.9). This reduces memory consumption
      for parsing all of std lib by about 40MB and makes parsing slightly
      faster.
      
      Change-Id: Iafb00b9c7f1be9c66fdfb29096d3da5049b2fcf5
      Reviewed-on: https://go-review.googlesource.com/33661Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
      11f8676b
    • Daniel Theophanes's avatar
      database/sql: do not bypass the driver locks with Context methods · 0d163ce1
      Daniel Theophanes authored
      When context methods were initially added it was attempted to unify
      behavior between drivers without Context methods and those with
      Context methods to always return right away when the Context expired.
      However in doing so the driver call could be executed outside of the
      scope of the driver connection lock and thus bypassing thread safety.
      
      The new behavior waits until the driver operation is complete. It then
      checks to see if the context has expired and if so returns that error.
      
      Change-Id: I4a5c7c3263420c57778f36a5ed6fa0ef8cb32b20
      Reviewed-on: https://go-review.googlesource.com/32422Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      0d163ce1
    • Dhananjay Nakrani's avatar
      cmd/go: report position info in package errors · 3825656e
      Dhananjay Nakrani authored
      Also refactor common position filling code into a function.
      
      Fixes #18011
      
      Change-Id: I76528626da67a7309193fa92af1e361c8e2fcf84
      Reviewed-on: https://go-review.googlesource.com/33631
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      3825656e
    • Hana Kim's avatar
      internal/pprof/profile: parse mutex profile including comments · b079869d
      Hana Kim authored
      Skip lines if they are empty or starting with "#" which are valid
      legacy pprof output format.
      
      Fixes #18025
      
      Change-Id: I7aee439171496932637b8ae3188700911f569b16
      Reviewed-on: https://go-review.googlesource.com/33454Reviewed-by: 's avatarPeter Weinberger <pjw@google.com>
      b079869d
    • Michal Bohuslávek's avatar
      net/http/httptest: fix typo in doc comment · 7a92d0b1
      Michal Bohuslávek authored
      Change-Id: I89f276b32015882437e128814573343a4ca53569
      Reviewed-on: https://go-review.googlesource.com/33615Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      7a92d0b1
    • Robert Griesemer's avatar
      cmd/compile: don't panic on syntax error in select statement · 8fa0d85b
      Robert Griesemer authored
      Fixes #18092.
      
      Change-Id: I54e2da2e0f168c068f5e4a1b22ba508d78259168
      Reviewed-on: https://go-review.googlesource.com/33658
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Run-TryBot: Robert Griesemer <gri@golang.org>
      Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
      8fa0d85b
    • Austin Clements's avatar
      runtime: fall back to /proc/self/auxv in Android libs · 6f287fa2
      Austin Clements authored
      Android's libc doesn't provide access to auxv, so currently the Go
      runtime synthesizes a fake, minimal auxv when loaded as a library on
      Android. This used to be sufficient, but now we depend on auxv to
      retrieve the system physical page size and panic if we can't retrieve
      it.
      
      Fix this by falling back to reading auxv from /proc/self/auxv if the
      loader-provided auxv is empty and removing the synthetic auxv vectors.
      
      Fixes #18041.
      
      Change-Id: Ia2ec2c764a6609331494a5d359032c56cbb83482
      Reviewed-on: https://go-review.googlesource.com/33652
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: 's avatarDavid Crawshaw <crawshaw@golang.org>
      6f287fa2
    • Austin Clements's avatar
      runtime: extract Linux auxv handling · d39b7b53
      Austin Clements authored
      This refactoring is in preparation for handling auxv differently in
      Android shared libraries.
      
      Updates #18041.
      
      Change-Id: If0458a309f9c804e7abd0a58b5a224d89f8da257
      Reviewed-on: https://go-review.googlesource.com/33651
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: 's avatarDavid Crawshaw <crawshaw@golang.org>
      d39b7b53
    • Brad Fitzpatrick's avatar
      doc: more go1.8.html updates · 5d1c6011
      Brad Fitzpatrick authored
      TBR=See https://golang.org/cl/33244
      
      Updates #17929
      
      Change-Id: I648df63aeb67aa2229c7b4fc23676a78b31140a0
      Reviewed-on: https://go-review.googlesource.com/33657Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      5d1c6011
    • Brad Fitzpatrick's avatar
      doc: update go1.8.html after feedback from Russ · 0c5c7c34
      Brad Fitzpatrick authored
      Address Russ's feedback from https://golang.org/cl/33244
      
      TBR=See https://golang.org/cl/33244
      
      Updates #17929
      
      Change-Id: I708d71f519f6414ecec629d3c273d9e737d8ed50
      Reviewed-on: https://go-review.googlesource.com/33656Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      0c5c7c34
    • Ian Lance Taylor's avatar
      cmd/link: handle STT_COMMON symbols · 45f75950
      Ian Lance Taylor authored
      Tested by running
      
      GOTRACEBACK=2 CGO_CFLAGS="-Wa,--elf-stt-common=yes" go test -ldflags=-linkmode=internal
      
      in misc/cgo/test. That failed before this CL, succeeded after.
      
      I don't think it's worth doing that as a regular test, though,
      especially since only recent versions of the GNU binutils support the
      --elf-stt-common option.
      
      Fixes #18088.
      
      Change-Id: I893d86181faee217b1504c054b0ed3f7c8d977d3
      Reviewed-on: https://go-review.googlesource.com/33653
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      45f75950
    • Russ Cox's avatar
      os: fix handling of Windows Unicode console input and ^Z · 610d5221
      Russ Cox authored
      Go 1.5 worked with Unicode console input but not ^Z.
      Go 1.6 did not work with Unicode console input but did handle one ^Z case.
      Go 1.7 did not work with Unicode console input but did handle one ^Z case.
      
      The intent of this CL is for Go 1.8 to work with Unicode console input
      and also handle all ^Z cases.
      
      Here's a simple test program for reading from the console.
      It prints a "> " prompt, calls read, prints what it gets, and repeats.
      
      	package main
      
      	import (
      	    "fmt"
      	    "os"
      	)
      
      	func main() {
      	    p := make([]byte, 100)
      	    fmt.Printf("> ")
      	    for {
      	        n, err := os.Stdin.Read(p)
      	        fmt.Printf("[%d %q %v]\n> ", n, p[:n], err)
      	    }
      	}
      
      On Unix, typing a ^D produces a break in the input stream.
      If the ^D is at the beginning of a line, then the 0 bytes returned
      appear as an io.EOF:
      
      	$ go run /tmp/x.go
      	> hello
      	[6 "hello\n" <nil>]
      	> hello^D[5 "hello" <nil>]
      	> ^D[0 "" EOF]
      	> ^D[0 "" EOF]
      	> hello^Dworld
      	[5 "hello" <nil>]
      	> [6 "world\n" <nil>]
      	>
      
      On Windows, the EOF character is ^Z, not ^D, and there has
      been a long-standing problem that in Go programs, ^Z on Windows
      does not behave in the expected way, namely like ^D on Unix.
      Instead, the ^Z come through as literal ^Z characters:
      
      	C:\>c:\go1.5.4\bin\go run x.go
      	> ^Z
      	[3 "\x1a\r\n" <nil>]
      	> hello^Zworld
      	[13 "hello\x1aworld\r\n" <nil>]
      	>
      
      CL 4310 attempted to fix this bug, then known as #6303,
      by changing the use of ReadConsole to ReadFile.
      This CL was released as part of Go 1.6 and did fix the case
      of a ^Z by itself, but not as part of a larger input:
      
      	C:\>c:\go1.6.3\bin\go run x.go
      	> ^Z
      	[0 "" EOF]
      	> hello^Zworld
      	[13 "hello\x1aworld\r\n" <nil>]
      	>
      
      So the fix was incomplete.
      Worse, the fix broke Unicode console input.
      
      ReadFile does not handle Unicode console input correctly.
      To handle Unicode correctly, programs must use ReadConsole.
      Early versions of Go used ReadFile to read the console,
      leading to incorrect Unicode handling, which was filed as #4760
      and fixed in CL 7312053, which switched to ReadConsole
      and was released as part of Go 1.1 and still worked as of Go 1.5:
      
      	C:\>c:\go1.5.4\bin\go run x.go
      	> hello
      	[7 "hello\r\n" <nil>]
      	> hello world
      	[16 "hello world\r\n" <nil>]
      	>
      
      But in Go 1.6:
      
      	C:\>c:\go1.6.3\bin\go run x.go
      	> hello
      	[7 "hello\r\n" <nil>]
      	> hello world
      	[0 "" EOF]
      	>
      
      That is, changing back to ReadFile in Go 1.6 reintroduced #4760,
      which has been refiled as #17097. (We have no automated test
      for this because we don't know how to simulate console input
      in a test: it appears that one must actually type at a keyboard
      to use the real APIs. This CL at least adds a comment warning
      not to reintroduce ReadFile again.)
      
      CL 29493 attempted to fix #17097, but it was not a complete fix:
      the hello world example above still fails, as does Shift-JIS input,
      which was filed as #17939.
      
      CL 29493 also broke ^Z handling, which was filed as #17427.
      
      This CL attempts the never before successfully performed trick
      of simultaneously fixing Unicode console input and ^Z handling.
      It changes the console input to use ReadConsole again,
      as in Go 1.5, which seemed to work for all known Unicode input.
      Then it adds explicit handling of ^Z in the input stream.
      (In the case where standard input is a redirected file, ^Z processing
      should not happen, and it does not, because this code path is only
      invoked when standard input is the console.)
      
      With this CL:
      
      	C:\>go run x.go
      	> hello
      	[7 "hello\r\n" <nil>]
      	> hello world
      	[16 "hello world\r\n" <nil>]
      	> ^Z
      	[0 "" EOF]
      	> [2 "\r\n" <nil>]
      	> hello^Zworld
      	[5 "hello" <nil>]
      	> [0 "" EOF]
      	> [7 "world\r\n" <nil>]
      
      This almost matches Unix:
      
      	$ go run /tmp/x.go
      	> hello
      	[6 "hello\n" <nil>]
      	> hello world
      	[15 "hello world\n" <nil>]
      	> ^D
      	[0 "" EOF]
      	> [1 "\n" <nil>]
      	> hello^Dworld
      	[5 "hello" <nil>]
      	> [6 "world\n" <nil>]
      	>
      
      The difference is in the handling of hello^Dworld / hello^Zworld.
      On Unix, hello^Dworld terminates the read of hello but does not
      result in a zero-length read between reading hello and world.
      This is dictated by the tty driver, not any special Go code.
      
      On Windows, in this CL, hello^Zworld inserts a zero length read
      result between hello and world, which is treated as an interior EOF.
      This is implemented by the Go code in this CL, but it matches the
      handling of ^Z on the console in other programs:
      
      	C:\>copy con x.txt
      	hello^Zworld
      	        1 file(s) copied.
      
      	C:\>type x.txt
      	hello
      	C:\>
      
      A natural question is how to test all this. As noted above, we don't
      know how to write automated tests using the actual Windows console.
      CL 29493 introduced the idea of substituting a different syscall.ReadFile
      implementation for testing; this CL continues that idea but substituting
      for syscall.ReadConsole instead. To avoid the regression of putting
      ReadFile back, this CL adds a comment warning against that.
      
      Fixes #17427.
      Fixes #17939.
      
      Change-Id: Ibaabd0ceb2d7af501d44ac66d53f64aba3944142
      Reviewed-on: https://go-review.googlesource.com/33451
      Run-TryBot: Russ Cox <rsc@golang.org>
      Reviewed-by: 's avatarQuentin Smith <quentin@golang.org>
      Reviewed-by: 's avatarAlex Brainman <alex.brainman@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      610d5221
    • David Crawshaw's avatar
      os: Executable can use /proc/self/exe on android · 8a2c34e4
      David Crawshaw authored
      Fixes the os test on the Android builder.
      
      Change-Id: Ibb9db712156a620fcccf515e035475c5e2f535a5
      Reviewed-on: https://go-review.googlesource.com/33650
      Run-TryBot: David Crawshaw <crawshaw@golang.org>
      Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      8a2c34e4
  2. 28 Nov, 2016 6 commits
  3. 26 Nov, 2016 1 commit
  4. 25 Nov, 2016 1 commit
    • Daniel Martí's avatar
      testing: comment out flag.Parse from example · 11106492
      Daniel Martí authored
      The TestMain docs explain that flag.Parse() should be called if TestMain
      itself depends on command-line flags.
      
      The issue here is that the example implementation does not use any
      flags, and thus the flag.Parse call is unnecessary. This leads to people
      who use this example as a starting point for their own implementations
      to forget that the call is not necessary in most cases.
      
      Comment it out instead of removing the line to keep it as a reminder, as
      suggested by Minux Ma.
      
      Change-Id: I6ffc5413e7036366ae3cf0f069b7065e832a3b45
      Reviewed-on: https://go-review.googlesource.com/33273Reviewed-by: 's avatarMinux Ma <minux@golang.org>
      Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      11106492
  5. 24 Nov, 2016 3 commits
  6. 23 Nov, 2016 8 commits
  7. 22 Nov, 2016 6 commits
    • Daniel Theophanes's avatar
      database/sql: fix TestPendingConnsAfterErr · e12f6ee0
      Daniel Theophanes authored
      TestPendingConnsAfterErr showed a failure on slower systems.
      Wait and check for the database to close all connections
      before pronouncing failure.
      
      A more careful method was attempted but the connection pool
      behavior is too dependent on the scheduler behavior to be
      predictable.
      
      Fixes #15684
      
      Change-Id: Iafdbc90ba51170c76a079db04c3d5452047433a4
      Reviewed-on: https://go-review.googlesource.com/33418Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      e12f6ee0
    • Joe Tsai's avatar
      doc: fix typos in go1.8.html · 199d410d
      Joe Tsai authored
      Change-Id: I51180e1c685e488f7ea4c51a63fd035148671b05
      Reviewed-on: https://go-review.googlesource.com/33470Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      199d410d
    • Brad Fitzpatrick's avatar
      doc: more go1.8.html content · f756204f
      Brad Fitzpatrick authored
      TBR=See https://golang.org/cl/33244 and review there.
      
      Updates #17929
      
      Change-Id: I7cb0b666469dba35426d1f0ae1b185e0bdfeac05
      Reviewed-on: https://go-review.googlesource.com/33474Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      f756204f
    • David du Colombier's avatar
      cmd/go: print CC environment variables on Plan 9 · 46323795
      David du Colombier authored
      This changes makes the output of `go env` the same
      as on other operating systems.
      
      Fixes #18013.
      
      Change-Id: I3079e14dcf7b30c75ec3fde6c78cb95721111320
      Reviewed-on: https://go-review.googlesource.com/33396Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      46323795
    • Michael Munday's avatar
      runtime/pprof/internal/protopprof: fix test on s390x · 55085611
      Michael Munday authored
      Applies the fix from CL 32920 to the new test TestSampledHeapAllocProfile
      introduced in CL 33422. The test should be skipped rather than fail if
      there is only one executable region of memory.
      
      Updates #17852.
      
      Change-Id: Id8c47b1f17ead14f02a58a024c9a04ebb8ec0429
      Reviewed-on: https://go-review.googlesource.com/33453
      Run-TryBot: Michael Munday <munday@ca.ibm.com>
      Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      55085611
    • Russ Cox's avatar
      runtime: do not print runtime panic frame at top of user stack · f9feaffd
      Russ Cox authored
      The expected default behavior (no explicit GOTRACEBACK setting)
      is for the stack trace to start in user code, eliding unnecessary runtime
      frames that led up to the actual trace printing code. The idea was that
      the first line number printed was the one that crashed.
      
      For #5832 we added code to show 'panic' frames so that if code panics
      and then starts running defers and then we trace from there, the panic
      frame can help explain why the code seems to have made a call not
      present in the code. But that's only needed for panics between two different
      call frames, not the panic at the very top of the stack trace.
      Fix the fix to again elide the runtime code at the very top of the stack trace.
      
      Simple panic:
      
      	package main
      
      	func main() {
      		var x []int
      		println(x[1])
      	}
      
      Before this CL:
      
      	panic: runtime error: index out of range
      
      	goroutine 1 [running]:
      	panic(0x1056980, 0x1091bf0)
      		/Users/rsc/go/src/runtime/panic.go:531 +0x1cf
      	main.main()
      		/tmp/x.go:5 +0x5
      
      After this CL:
      
      	panic: runtime error: index out of range
      
      	goroutine 1 [running]:
      	main.main()
      		/tmp/x.go:5 +0x5
      
      Panic inside defer triggered by panic:
      
      	package main
      
      	func main() {
      		var x []int
      		defer func() {
      			println(x[1])
      		}()
      		println(x[2])
      	}
      
      Before this CL:
      
      	panic: runtime error: index out of range
      		panic: runtime error: index out of range
      
      	goroutine 1 [running]:
      	panic(0x1056aa0, 0x1091bf0)
      		/Users/rsc/go/src/runtime/panic.go:531 +0x1cf
      	main.main.func1(0x0, 0x0, 0x0)
      		/tmp/y.go:6 +0x62
      	panic(0x1056aa0, 0x1091bf0)
      		/Users/rsc/go/src/runtime/panic.go:489 +0x2cf
      	main.main()
      		/tmp/y.go:8 +0x59
      
      The middle panic is important: it explains why main.main ended up calling main.main.func1 on a line that looks like a call to println. The top panic is noise.
      
      After this CL:
      
      	panic: runtime error: index out of range
      		panic: runtime error: index out of range
      
      	goroutine 1 [running]:
      	main.main.func1(0x0, 0x0, 0x0)
      		/tmp/y.go:6 +0x62
      	panic(0x1056ac0, 0x1091bf0)
      		/Users/rsc/go/src/runtime/panic.go:489 +0x2cf
      	main.main()
      		/tmp/y.go:8 +0x59
      
      Fixes #17901.
      
      Change-Id: Id6d7c76373f7a658a537a39ca32b7dc23e1e76aa
      Reviewed-on: https://go-review.googlesource.com/33165
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      f9feaffd