Skip to content

G
golang
Switch branch/tag
  1. 10 Dec, 2012 10 commits
  3. 09 Dec, 2012 4 commits
  5. 08 Dec, 2012 2 commits
  7. 07 Dec, 2012 2 commits
    • Russ Cox's avatar
      math/rand: add example / regression test · b99161e4
      Russ Cox authored 
      This makes sure the outputs do not change for a fixed seed.
See also https://golang.org/cl/6905049.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6907048
      b99161e4
    • Russ Cox's avatar
      undo CL 6845121 / 79603a5e4cda · ff2534e0
      Russ Cox authored 
      This changes the output of

rand.Seed(0)
perm := rand.Perm(100)

When giving the same seeds to Go 1.0 and Go 1.1 programs
I would like them to generate the same random numbers.

««« original CL description
math/rand: remove noop iteration in Perm

The first iteration always do `m[0], m[0] = m[0], m[0]`, because
`rand.Intn(1)` is 0.

fun note: IIRC in TAOCP version of this algorithm, `i` goes
backward (n-1->1), meaning that the "already" shuffled part of the
array is never altered betweens iterations, while in the current
implementation the "not-yet" shuffled part of the array is
conserved between iterations.

R=golang-dev
CC=golang-dev
https://golang.org/cl/6845121

»»»

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6905049
      ff2534e0
  9. 06 Dec, 2012 17 commits
  11. 05 Dec, 2012 5 commits
    • Ian Lance Taylor's avatar
      gc: avoid meaningless constant overflow error for inverted slice range · 08918ba4
      Ian Lance Taylor authored 
      Used to say:

issue4251.go:12: inverted slice range
issue4251.go:12: constant -1 overflows uint64
issue4251.go:16: inverted slice range
issue4251.go:16: constant -1 overflows uint64
issue4251.go:20: inverted slice range
issue4251.go:20: constant -1 overflows uint64

With this patch, only gives the "inverted slice range" errors.

R=golang-dev, daniel.morsing
CC=golang-dev
https://golang.org/cl/6871058
      08918ba4
    • Dave Cheney's avatar
      cmd/5g: use MOVB for fixed array nil check · 54e8d504
      Dave Cheney authored 
      Fixes #4396.

For fixed arrays larger than the unmapped page, agenr would general a nil check by loading the first word of the array. However there is no requirement for the first element of a byte array to be word aligned, so this check causes a trap on ARMv5 hardware (ARMv6 since relaxed that restriction, but it probably still comes at a cost).

Switching the check to MOVB ensures alignment is not an issue. This check is only invoked in a few places in the code where large fixed arrays are embedded into structs, compress/lzw is the biggest offender, and switching to MOVB has no observable performance penalty.

Thanks to Rémy and Daniel Morsing for helping me debug this on IRC last night.

R=remyoudompheng, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6854063
      54e8d504
    • Dave Cheney's avatar
      net: fix data races on deadline vars · 9fb96991
      Dave Cheney authored 
      Fixes #4434.

This proposal replaces the previous CL 6855110. Due to issue 599, 64-bit atomic operations should probably be avoided, so use a sync.Mutex instead.

Benchmark comparisons against 025b9d070a85 on linux/386:

CL 6855110:

benchmark                        old ns/op    new ns/op    delta
BenchmarkTCPOneShot                 710024       727409   +2.45%
BenchmarkTCPOneShotTimeout          758178       768620   +1.38%
BenchmarkTCPPersistent              223464       228058   +2.06%
BenchmarkTCPPersistentTimeout       234494       242600   +3.46%

This proposal:

benchmark                        old ns/op    new ns/op    delta
BenchmarkTCPOneShot                 710024       718492   +1.19%
BenchmarkTCPOneShotTimeout          758178       748783   -1.24%
BenchmarkTCPPersistent              223464       227628   +1.86%
BenchmarkTCPPersistentTimeout       234494       238321   +1.63%

R=rsc, dvyukov, mikioh.mikioh, alex.brainman, bradfitz
CC=golang-dev, remyoudompheng
https://golang.org/cl/6866050
      9fb96991
    • Alex Brainman's avatar
      net: change windows netFD finalizer to behave similar to unix · 4855c1c1
      Alex Brainman authored 
      R=dave, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6873046
      4855c1c1
    • Brad Fitzpatrick's avatar
      net/http: clarify DefaultTransport docs · a7c57b05
      Brad Fitzpatrick authored 
      Fixes #4281

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6872053
      a7c57b05