1. 10 Feb, 2014 3 commits
  2. 09 Feb, 2014 5 commits
  3. 07 Feb, 2014 11 commits
  4. 06 Feb, 2014 5 commits
    • Jakub Ryszard Czarnowicz's avatar
      net/mail: correctly handle whitespaces when formatting an email address · d3b9567a
      Jakub Ryszard Czarnowicz authored
      Whitespace characters are allowed in quoted-string according to RFC 5322 without
      being "Q"-encoding. Address.String() already always formats the name portion in
      quoted string, so whitespace characters should be allowed in there.
      
      Fixes #6641.
      
      LGTM=dave, dsymonds
      R=golang-codereviews, gobot, dsymonds, dave
      CC=golang-codereviews
      https://golang.org/cl/55770043
      d3b9567a
    • Shenghou Ma's avatar
      cmd/go: do not create world-writable files. · c66956cd
      Shenghou Ma authored
      Fixes #7240.
      
      LGTM=tommi.virtanen, bradfitz
      R=golang-codereviews, tommi.virtanen, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/60480045
      c66956cd
    • Richard Musiol's avatar
      math/big: replace goto with for loop · 547a82c3
      Richard Musiol authored
      I just added support for goto statements to my GopherJS project and now I am trying to get rid of my patches. These occurrences of goto however are a bit problematic:
      GopherJS has to emulate gotos, so there is some performance drawback when doing so. In this case the drawback is major, since this is a core function of math/big which is called quite often. Additionally I can't see any reason here why the implementation with gotos should be preferred over my proposal.
      That's why I would kindly ask to include this patch, even though it is functional equivalent to the existing code.
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/55470046
      547a82c3
    • Shenghou Ma's avatar
      doc/install.html: get rid of explicit version number in docs. · 2b6eb111
      Shenghou Ma authored
      So that we don't need to update the file each time a new version is released.
      
      LGTM=dave, r, adg
      R=golang-codereviews, dave, josharian, gobot, adg, r
      CC=golang-codereviews
      https://golang.org/cl/48730043
      2b6eb111
    • Elias Naur's avatar
      cmd/go, cmd/cgo, make.bash: cross compiling with cgo enabled · 2dc759d7
      Elias Naur authored
      Introduce two new environment variables, CC_FOR_TARGET and CXX_FOR_TARGET.
      CC_FOR_TARGET defaults to CC and is used when compiling for GOARCH, while
      CC remains for compiling for GOHOSTARCH.
      CXX_FOR_TARGET defaults to CXX and is used when compiling C++ code for
      GOARCH.
      
      CGO_ENABLED defaults to disabled when cross compiling and has to be
      explicitly enabled.
      
      Update #4714
      
      LGTM=minux.ma, iant
      R=golang-codereviews, minux.ma, iant, rsc, dominik.honnef
      CC=golang-codereviews
      https://golang.org/cl/57100043
      2dc759d7
  5. 05 Feb, 2014 2 commits
  6. 04 Feb, 2014 4 commits
  7. 03 Feb, 2014 6 commits
    • Elias Naur's avatar
      liblink, cmd/5l: restore flag_shared · 9ed5995c
      Elias Naur authored
      CL 56120043 fixed and cleaned up TLS on ARM after introducing liblink, but
      left flag_shared broken. This CL restores the (unsupported) flag_shared
      behaviour by simply rewriting access to $runtime.tlsgm(SB) with
      runtime.tlsgm(SB), to compensate for the extra indirection when going from
      the R_ARM_TLS_LE32 relocation to the R_ARM_TLS_IE32 relocation.
      
      Also, remove unnecessary symbol lookup left after 56120043.
      
      LGTM=iant
      R=iant, rsc
      CC=golang-codereviews
      https://golang.org/cl/57000043
      9ed5995c
    • Elias Naur's avatar
      liblink, cmd/5a, cmd/5l: restore cgo on older ARM processors · 1dd4da14
      Elias Naur authored
      CL 56120043 fixed TLS handling on ARM after the introduction of
      liblink but left older ARM processors broken.
      
      Before liblink, the MRC instruction was replaced with a fallback
      on older ARMs. CL 56120043 removed that, because the rewrite matched
      bit patterns on the AWORD pseudo-instruction and could therefore change
      unrelated AWORDs that happened to match.
      
      This CL adds an AMRC instruction to encode both MRC and MCR previously
      encoded as AWORDs. Then, in liblink, the AMRC instructions are either
      rewritten to AWORD, or, on goarm < 7, replaced with a branch to the
      fallback.
      
      ./all.bash completes successfully on an ARMv7 with either GOARM=7 or
      GOARM=5. I have verified that the fallback is indeed present in both
      runtime.save_gm and runtime.load_gm when GOARM=5 but not when GOARM=7.
      
      If all goes well, this should fix the armv5 builders.
      
      LGTM=iant
      R=iant, rsc
      CC=golang-codereviews
      https://golang.org/cl/55540044
      1dd4da14
    • Brad Fitzpatrick's avatar
      os/exec: fix Command with relative paths · e6d8bfe2
      Brad Fitzpatrick authored
      Command was (and is) documented like:
      "If name contains no path separators, Command uses LookPath to
      resolve the path to a complete name if possible. Otherwise it
      uses name directly."
      
      But that wasn't true. It always did LookPath, and then
      set a sticky error that the user couldn't unset.
      And then if cmd.Dir was changed, Start would still fail
      due to the earlier sticky error being set.
      
      This keeps LookPath in the same place as before (so no user
      visible changes in cmd.Path after Command), but only does
      it when the documentation says it will happen.
      
      Also, clarify the docs about a relative Dir path.
      
      No change in any existing behavior, except using Command
      is now possible with relative paths. Previously it only
      worked if you built the *Cmd by hand.
      
      Fixes #7228
      
      LGTM=iant
      R=iant
      CC=adg, golang-codereviews
      https://golang.org/cl/59580044
      e6d8bfe2
    • Brad Fitzpatrick's avatar
      net/http: make a test fail harder, earlier · 4723308f
      Brad Fitzpatrick authored
      LGTM=dave
      R==r, r, dave
      CC=golang-codereviews
      https://golang.org/cl/59810043
      4723308f
    • Robert Griesemer's avatar
      A+C: Gordon Klaus (individual CLA) · 07cbf550
      Robert Griesemer authored
      Generated by addca.
      
      LGTM=iant
      R=gobot, iant
      CC=golang-codereviews
      https://golang.org/cl/59770043
      07cbf550
    • Brad Fitzpatrick's avatar
      A+C: 申习之 (individual CLA) · 9a960042
      Brad Fitzpatrick authored
      Generated by addca.
      
      TBR=iant
      R=gobot
      CC=golang-codereviews
      https://golang.org/cl/59550044
      9a960042
  8. 02 Feb, 2014 4 commits