- 10 Feb, 2014 3 commits
-
-
Dmitriy Vyukov authored
Currently this leads to a significant skew towards 'etext' entry, since all idle threads are profiled every tick. Before: Total: 66608 samples 63188 94.9% 94.9% 63188 94.9% etext 278 0.4% 95.3% 278 0.4% sweepspan 216 0.3% 95.6% 448 0.7% runtime.mallocgc 122 0.2% 95.8% 122 0.2% scanblock 113 0.2% 96.0% 113 0.2% net/textproto.canonicalMIMEHeaderKey After: Total: 8008 samples 3949 49.3% 49.3% 3949 49.3% etext 231 2.9% 52.2% 231 2.9% scanblock 211 2.6% 54.8% 211 2.6% runtime.cas64 182 2.3% 57.1% 408 5.1% runtime.mallocgc 178 2.2% 59.3% 178 2.2% runtime.atomicload64 LGTM=alex.brainman R=golang-codereviews, alex.brainman CC=golang-codereviews https://golang.org/cl/61250043
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz, alex.brainman CC=golang-codereviews https://golang.org/cl/61260044
-
Dave Cheney authored
Fixes #7293. Update #7261 The bsd ld(1) does not understand $ORIGIN and has restrictions on using -rpath when using clang(1), the default compiler on darwin. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/58480045
-
- 09 Feb, 2014 5 commits
-
-
Dave Cheney authored
Fixes #7260. Fix three broken tests in test.bash The test for issue 4568 was confused by go $ACTION . producing a package root of "", avoiding this mode fixes the test but weakens the test. The test for issue 4773 was broken on linux because math/Rand would fail to resolve as a package causing the test for duplicates to be skipped. Finally, the last breakage was a small change in the error message. Also, add test for foldDup. LGTM=iant R=iant, rsc CC=golang-codereviews https://golang.org/cl/61070044
-
Brad Fitzpatrick authored
LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/60530049
-
Shenghou Ma authored
rsc suggested that we split the whole linker changes into three parts. This is the first one, mostly dealing with adding Hsolaris. LGTM=iant R=golang-codereviews, iant, dave CC=golang-codereviews https://golang.org/cl/54210050
-
Andrew Gerrand authored
LGTM=bradfitz R=dave, bradfitz CC=golang-codereviews https://golang.org/cl/61310043
-
Mikio Hara authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/54300054
-
- 07 Feb, 2014 11 commits
-
-
Rémy Oudompheng authored
This changes makes sgen and clearfat use unaligned instructions for the trailing bytes, like the runtime memmove does, resulting in faster code when manipulating types whose size is not a multiple of 8. LGTM=khr R=khr, iant, rsc CC=golang-codereviews https://golang.org/cl/51740044
-
David du Colombier authored
LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/60590047
-
David du Colombier authored
LGTM=iant R=golang-codereviews, dave, iant CC=golang-codereviews https://golang.org/cl/60740044
-
Alex Brainman authored
LGTM=minux.ma, dvyukov R=golang-codereviews, minux.ma, dvyukov CC=golang-codereviews https://golang.org/cl/60900043
-
Keith Randall authored
Use explicit SSE writes instead of REP STOSQ. benchmark old ns/op new ns/op delta BenchmarkMemclr5 22 5 -73.62% BenchmarkMemclr16 27 5 -78.49% BenchmarkMemclr64 28 6 -76.43% BenchmarkMemclr256 34 8 -74.94% BenchmarkMemclr4096 112 84 -24.73% BenchmarkMemclr65536 1902 1920 +0.95% LGTM=dvyukov R=golang-codereviews, dvyukov CC=golang-codereviews https://golang.org/cl/60090044
-
Alex Brainman authored
filepath.Base covers all scenarios (for example paths like d:hello.txt) on windows LGTM=iant, bradfitz R=golang-codereviews, iant, bradfitz CC=golang-codereviews https://golang.org/cl/59740050
-
Mikio Hara authored
This CL is in preparation to make cgo work on freebsd/arm. The signedness of C char might be a problem when we make bare syscall APIs, Go structures, using built-in bootstrap scripts with cgo because they do translate C stuff to Go stuff internally. For now almost all the C compilers assume that the type of char will be unsigned on arm by default but it makes a different view from amd64, 386. This CL just passes -fsigned-char, let the type of char be signed, option which is supported on both gcc and clang to the underlying C compilers through cgo for avoiding such inconsistency on syscall API. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/59740051
-
Mikio Hara authored
This CL is in preparation to make cgo work on freebsd/arm. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/59490051
-
Mikio Hara authored
This CL is in preparation to make cgo work on freebsd/arm. It's just for fixing build fails on freebsd/arm, we still need to update z-files later for fixing several package test fails. How to generate z-files on freebsd/arm in the bootstrapping phase: 1. run freebsd on appropriate arm-eabi platforms 2. both syscall z-files and runtime def-files in the current tree are broken about EABI padding, fix them by hand 3. run make.bash again to build $GOTOOLDIR/cgo 4. use $GOTOOLDIR/cgo directly LGTM=iant R=iant, dave CC=golang-codereviews https://golang.org/cl/59490052
-
Mikio Hara authored
This CL is in preparation to make cgo work on freebsd/arm. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/60500044
-
Mikio Hara authored
This CL is in preparation to make cgo work on freebsd/arm. How to generate defs-files on freebsd/arm in the bootstrapping phase: 1. run freebsd on appropriate arm-eabi platforms 2. both syscall z-files and runtime def-files in the current tree are broken about EABI padding, fix them by hand 3. run make.bash again to build $GOTOOLDIR/cgo 4. use $GOTOOLDIR/cgo directly LGTM=minux.ma, iant R=iant, minux.ma, dave CC=golang-codereviews https://golang.org/cl/59580045
-
- 06 Feb, 2014 5 commits
-
-
Jakub Ryszard Czarnowicz authored
Whitespace characters are allowed in quoted-string according to RFC 5322 without being "Q"-encoding. Address.String() already always formats the name portion in quoted string, so whitespace characters should be allowed in there. Fixes #6641. LGTM=dave, dsymonds R=golang-codereviews, gobot, dsymonds, dave CC=golang-codereviews https://golang.org/cl/55770043
-
Shenghou Ma authored
Fixes #7240. LGTM=tommi.virtanen, bradfitz R=golang-codereviews, tommi.virtanen, bradfitz CC=golang-codereviews https://golang.org/cl/60480045
-
Richard Musiol authored
I just added support for goto statements to my GopherJS project and now I am trying to get rid of my patches. These occurrences of goto however are a bit problematic: GopherJS has to emulate gotos, so there is some performance drawback when doing so. In this case the drawback is major, since this is a core function of math/big which is called quite often. Additionally I can't see any reason here why the implementation with gotos should be preferred over my proposal. That's why I would kindly ask to include this patch, even though it is functional equivalent to the existing code. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/55470046
-
Shenghou Ma authored
So that we don't need to update the file each time a new version is released. LGTM=dave, r, adg R=golang-codereviews, dave, josharian, gobot, adg, r CC=golang-codereviews https://golang.org/cl/48730043
-
Elias Naur authored
Introduce two new environment variables, CC_FOR_TARGET and CXX_FOR_TARGET. CC_FOR_TARGET defaults to CC and is used when compiling for GOARCH, while CC remains for compiling for GOHOSTARCH. CXX_FOR_TARGET defaults to CXX and is used when compiling C++ code for GOARCH. CGO_ENABLED defaults to disabled when cross compiling and has to be explicitly enabled. Update #4714 LGTM=minux.ma, iant R=golang-codereviews, minux.ma, iant, rsc, dominik.honnef CC=golang-codereviews https://golang.org/cl/57100043
-
- 05 Feb, 2014 2 commits
-
-
Brad Fitzpatrick authored
Generated by addca. TBR=iant R=gobot CC=golang-codereviews https://golang.org/cl/52350044
-
Shenghou Ma authored
Fixes #7034. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/57140043
-
- 04 Feb, 2014 4 commits
-
-
Josh Bleecher Snyder authored
Fixes #7016. LGTM=r R=r CC=adg, bradfitz, dave, golang-codereviews https://golang.org/cl/60100043
-
Josh Bleecher Snyder authored
Fixes #7117. LGTM=gri R=golang-codereviews, gobot, gri CC=golang-codereviews https://golang.org/cl/53310044
-
Anthony Martin authored
This reduces the ability to fingerprint TLS connections. The impeteus for this change was a recent change to OpenSSL by Nick Mathewson: http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=2016265dfb LGTM=agl R=agl CC=golang-codereviews https://golang.org/cl/57230043
-
Dmitriy Vyukov authored
Add benchmarks for: 1. non-blocking failing receive (polling of "stop" chan) 2. channel-based semaphore (gate pattern) 3. select-based producer/consumer (pass data through a channel, but also wait on "stop" and "timeout" channels) LGTM=r R=golang-codereviews, r CC=bradfitz, golang-codereviews, iant, khr https://golang.org/cl/59040043
-
- 03 Feb, 2014 6 commits
-
-
Elias Naur authored
CL 56120043 fixed and cleaned up TLS on ARM after introducing liblink, but left flag_shared broken. This CL restores the (unsupported) flag_shared behaviour by simply rewriting access to $runtime.tlsgm(SB) with runtime.tlsgm(SB), to compensate for the extra indirection when going from the R_ARM_TLS_LE32 relocation to the R_ARM_TLS_IE32 relocation. Also, remove unnecessary symbol lookup left after 56120043. LGTM=iant R=iant, rsc CC=golang-codereviews https://golang.org/cl/57000043
-
Elias Naur authored
CL 56120043 fixed TLS handling on ARM after the introduction of liblink but left older ARM processors broken. Before liblink, the MRC instruction was replaced with a fallback on older ARMs. CL 56120043 removed that, because the rewrite matched bit patterns on the AWORD pseudo-instruction and could therefore change unrelated AWORDs that happened to match. This CL adds an AMRC instruction to encode both MRC and MCR previously encoded as AWORDs. Then, in liblink, the AMRC instructions are either rewritten to AWORD, or, on goarm < 7, replaced with a branch to the fallback. ./all.bash completes successfully on an ARMv7 with either GOARM=7 or GOARM=5. I have verified that the fallback is indeed present in both runtime.save_gm and runtime.load_gm when GOARM=5 but not when GOARM=7. If all goes well, this should fix the armv5 builders. LGTM=iant R=iant, rsc CC=golang-codereviews https://golang.org/cl/55540044
-
Brad Fitzpatrick authored
Command was (and is) documented like: "If name contains no path separators, Command uses LookPath to resolve the path to a complete name if possible. Otherwise it uses name directly." But that wasn't true. It always did LookPath, and then set a sticky error that the user couldn't unset. And then if cmd.Dir was changed, Start would still fail due to the earlier sticky error being set. This keeps LookPath in the same place as before (so no user visible changes in cmd.Path after Command), but only does it when the documentation says it will happen. Also, clarify the docs about a relative Dir path. No change in any existing behavior, except using Command is now possible with relative paths. Previously it only worked if you built the *Cmd by hand. Fixes #7228 LGTM=iant R=iant CC=adg, golang-codereviews https://golang.org/cl/59580044
-
Brad Fitzpatrick authored
LGTM=dave R==r, r, dave CC=golang-codereviews https://golang.org/cl/59810043
-
Robert Griesemer authored
Generated by addca. LGTM=iant R=gobot, iant CC=golang-codereviews https://golang.org/cl/59770043
-
Brad Fitzpatrick authored
Generated by addca. TBR=iant R=gobot CC=golang-codereviews https://golang.org/cl/59550044
-
- 02 Feb, 2014 4 commits
-
-
Brad Fitzpatrick authored
Generated by addca. TBR=iant R=gobot CC=golang-codereviews https://golang.org/cl/51430044
-
Brad Fitzpatrick authored
Generated by addca. TBR=iant R=gobot CC=golang-codereviews https://golang.org/cl/59410044
-
Brad Fitzpatrick authored
Generated by addca. TBR=iant R=gobot CC=golang-codereviews https://golang.org/cl/59450044
-
Brad Fitzpatrick authored
Generated by addca. TBR=iant R=gobot CC=golang-codereviews https://golang.org/cl/59460043
-