Commits · 057f7d5b0700fd3867ccb930e9114560b43152b1 · go / golang

23 Oct, 2009 4 commits
- s/pc/PC/ in traceback output to match amd64. · 057f7d5b
  Ian Lance Taylor authored Oct 23, 2009
```
test/run expects to see "PC".

R=rsc
http://go/go-review/1015002
```
  057f7d5b
- Fix printer_test.go to invoke Fprint as a method of cfg. · 95499a27
  Ian Lance Taylor authored Oct 23, 2009
```
This matches the change to printer.go in revision 3632.

R=gri
http://go/go-review/1015001
```
  95499a27
- - make printer interface easily extensible w/o breaking clients (in the future) · 8f52a821
  Robert Griesemer authored Oct 23, 2009
```
- replacement for p4 CL 35999 (abandoned)

R=rsc
http://go/go-review/1012010
```
  8f52a821
- minor changes to walk · abc6ad42
  Robert Griesemer authored Oct 23, 2009
```
R=rsc
http://go/go-review/1012008
```
  abc6ad42
22 Oct, 2009 20 commits

simple AST walking support · ba15bbe6
Robert Griesemer authored Oct 22, 2009
```
R=rsc
http://go/go-review/1014006
```
ba15bbe6
silly change to test the code review process · 242788b0
Rob Pike authored Oct 22, 2009
```
R=rsc
http://go/go-review/1013009
```
242788b0
add codereview-login command · 439f9ca8
Russ Cox authored Oct 22, 2009
```
R=r
CC=go-dev
http://go/go-review/1012007
```
439f9ca8
fix build: no acid · 8a20cfc0
Rob Pike authored Oct 22, 2009
```
R=rsc
http://go/go-review/1014005
```
8a20cfc0
fix handling of escaped characters like ' " & < > · eea25730
Russ Cox authored Oct 22, 2009
```
R=r
http://go/go-review/1013007
```
eea25730

Initial checkin of codereview plugin. · 79a63728

Russ Cox authored Oct 22, 2009

The master copy is going to live elsewhere,
but weAPOSTROPHEll keep a copy in the Go tree so that
developers donAPOSTROPHEt have to check out two
different repositories.

R=r
CC=go-dev
http://go/go-review/1012006

79a63728

tell Mercurial which files to ignore · 6d96b24e
Russ Cox authored Oct 22, 2009
```
R=r
CC=go-dev
http://go/go-review/1012005
```
6d96b24e

fix build after Mercurial move. · 219fb020

Russ Cox authored Oct 22, 2009

various missing or incorrect files.

R=r
CC=go-dev
http://go/go-review/1014004

219fb020

go/printer: · 90cc4a59

Robert Griesemer authored Oct 22, 2009

- handle HTML tagging via (client-installable) Stylers

go/doc:
- basic styler support
- some factoring
- ready to contain the search code (but for now excluded)

doc/style.css:
- updated

doc/go_spec.css:
- cleanup: replace deprecated uses of <font> tag with <span> tag

R=rsc
DELTA=302  (160 added, 62 deleted, 80 changed)
OCL=35973
CL=35996

90cc4a59

Interface types, values, and type compiler. This does not yet · 3040f067

Austin Clements authored Oct 22, 2009

implement any type checking or semantics for interfaces.

R=rsc
APPROVED=rsc
DELTA=305  (289 added, 10 deleted, 6 changed)
OCL=35889
CL=35995

3040f067

go-mode for Emacs. This provides basic syntax highlighting · 5bd8c924

Austin Clements authored Oct 22, 2009

for keywords, built-ins, functions, and some types.  It also
provides indentation that is (almost) identical to gofmt.

R=rsc
APPROVED=rsc
DELTA=509  (509 added, 0 deleted, 0 changed)
OCL=35951
CL=35994

5bd8c924

add FAQ · 3227445b

Russ Cox authored Oct 22, 2009

R=r
DELTA=13  (0 added, 8 deleted, 5 changed)
OCL=35985
CL=35987

3227445b

main landing pages · 09fe2834

Russ Cox authored Oct 22, 2009

R=r
DELTA=55  (7 added, 34 deleted, 14 changed)
OCL=35984
CL=35986

09fe2834

drop a couple of semicolons for consistency · 2cf9dae1
Rob Pike authored Oct 22, 2009
```
R=rsc
DELTA=4  (0 added, 0 deleted, 4 changed)
OCL=35983
CL=35983
```
2cf9dae1

have http server in-line PDF files. · c6e904d5

Rob Pike authored Oct 22, 2009

add go course pdf files to doc/ for godoc to serve.
fix links to point to those files.

R=rsc
DELTA=7  (4 added, 0 deleted, 3 changed)
OCL=35972
CL=35981

c6e904d5

Add SetValue(Value) to the Value interface. · a8a678fc
Adam Langley authored Oct 22, 2009
```
R=rsc
APPROVED=rsc
DELTA=172  (170 added, 0 deleted, 2 changed)
OCL=35969
CL=35980
```
a8a678fc
fix typo/oversight: s/Title/ToTitle/. the comment was already correct · f1b91263
Rob Pike authored Oct 22, 2009
```
R=rsc
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=35964
CL=35979
```
f1b91263
Replace SliceReader with bytes.Buffer. · 1d390cec
Adam Langley authored Oct 22, 2009
```
R=r
APPROVED=r
DELTA=16  (0 added, 15 deleted, 1 changed)
OCL=35976
CL=35978
```
1d390cec
Fix typo in documentation. · 7d68093f
Adam Langley authored Oct 22, 2009
```
R=r
APPROVED=r
DELTA=2  (1 added, 0 deleted, 1 changed)
OCL=35977
CL=35977
```
7d68093f

Add initial x509 code. · fd74a835

Adam Langley authored Oct 22, 2009

R=rsc
APPROVED=rsc
DELTA=659  (659 added, 0 deleted, 0 changed)
OCL=35932
CL=35975

fd74a835

21 Oct, 2009 4 commits

Match gccgo error messages. · d7ad3c4e

Ian Lance Taylor authored Oct 21, 2009

bug205.go:14:12: error: index must be integer
bug205.go:15:12: error: index must be integer
bug205.go:16:12: error: incompatible type for map index

R=rsc
DELTA=2  (0 added, 0 deleted, 2 changed)
OCL=35957
CL=35960

d7ad3c4e

change stack splitting comparisons from signed to unsigned (oversight) · c2eb89af
Kai Backman authored Oct 21, 2009
```
R=rsc
APPROVED=rsc
DELTA=9  (0 added, 0 deleted, 9 changed)
OCL=35911
CL=35952
```
c2eb89af

gccgo does not distinguish "use" and "assign" in these error · fbba532f

Ian Lance Taylor authored Oct 21, 2009

messages. Match gccgo output.

named1.go:32:2: error: argument 0 has wrong type (cannot use type bool as type Bool)
named1.go:33:2: error: argument 0 has wrong type (cannot use type bool as type Bool)
named1.go:35:5: error: incompatible type for map index (cannot use type bool as type Bool)
named1.go:36:12: error: incompatible type for map assignment (cannot use type Bool as type bool)
named1.go:38:5: error: incompatible types in assignment (cannot use type bool as type Bool)
named1.go:40:2: error: argument 0 has wrong type (cannot use type bool as type Bool)
named1.go:42:5: error: incompatible type for receive (cannot use type bool as type Bool)
named1.go:46:5: error: incompatible type for type guard (cannot use type bool as type Bool)
named1.go:50:5: error: incompatible type for type guard (cannot use type bool as type Bool)
named1.go:53:2: error: argument 0 has wrong type (cannot use type bool as type Bool)
named1.go:54:5: error: incompatible types in assignment (cannot use type bool as type Bool)

R=rsc
DELTA=4 (0 added, 0 deleted, 4 changed)
OCL=35943
CL=35943

fbba532f

initialization · 6f89f3f0

Rob Pike authored Oct 21, 2009

R=rsc
DELTA=292  (124 added, 165 deleted, 3 changed)
OCL=35936
CL=35939

6f89f3f0

20 Oct, 2009 12 commits

Move usr/dsymonds/iterable to src/pkg/exp/iterable. · 69fc06df

David Symonds authored Oct 20, 2009

Remove remainder of usr/dsymonds.

R=rsc,r
APPROVED=r
DELTA=685  (275 added, 409 deleted, 1 changed)
OCL=35810
CL=35933

69fc06df

remove superfluous tracing support · f591591a
Robert Griesemer authored Oct 20, 2009
```
R=rsc
DELTA=5  (0 added, 4 deleted, 1 changed)
OCL=35930
CL=35930
```
f591591a

base64 -> encoding/base64 · 357b770d

Russ Cox authored Oct 20, 2009

base85 -> encoding/ascii85, encoding/git85
debug/binary -> encoding/binary

R=r
DELTA=3190  (1884 added, 1297 deleted, 9 changed)
OCL=35923
CL=35929

357b770d

start the concurrency discussion. work from the outside in because this is a toughie. · 430d4623
Rob Pike authored Oct 20, 2009
```
also fix a pedantry in the language design faq.

R=rsc
DELTA=113  (94 added, 16 deleted, 3 changed)
OCL=35922
CL=35928
```
430d4623

Updated and simplified gofmt. · 4213c223

Robert Griesemer authored Oct 20, 2009

- operates on stdin, a single file, or all files in a file tree
- setting -w flag writes to (source) file instead of stdout
- setting -l flag lists files whose formatting has changed

R=rsc
DELTA=201  (102 added, 71 deleted, 28 changed)
OCL=35890
CL=35926

4213c223

Add base85, based on base64. · fcc4be8c

Russ Cox authored Oct 20, 2009

Also add git version of base85,
which is what I really wanted but
didn't recognize as different until it
was too late.

R=austin
DELTA=980  (972 added, 4 deleted, 4 changed)
OCL=35580
CL=35921

fcc4be8c

address bug193 and add note to spec about it. · 60ff8cc8
Russ Cox authored Oct 20, 2009
```
R=ken
OCL=35920
CL=35920
```
60ff8cc8
bug162, over and over · 02fd255a
Russ Cox authored Oct 20, 2009
```
R=ken
OCL=35919
CL=35919
```
02fd255a
forgot to include in 35898. · d6b64f27
Russ Cox authored Oct 20, 2009
```
R=ken
OCL=35917
CL=35917
```
d6b64f27

removed tempalloc/tempfree and replaced with tempname · dde40903

Kai Backman authored Oct 20, 2009

go/test: passes 88% (304/345)

R=rsc
APPROVED=rsc
DELTA=67  (3 added, 54 deleted, 10 changed)
OCL=35910
CL=35910

dde40903

support for 5.out files · fcb93870

Russ Cox authored Oct 20, 2009

R=kaib
DELTA=1262  (1247 added, 7 deleted, 8 changed)
OCL=35907
CL=35909

fcb93870

getcallerpc and setcallerpc · 33a7bcf3

Kai Backman authored Oct 20, 2009

go/test: passes 87% (303/345)

R=rsc
APPROVED=rsc
DELTA=19  (5 added, 6 deleted, 8 changed)
OCL=35903
CL=35906

33a7bcf3