1. 09 Jul, 2014 11 commits
  2. 08 Jul, 2014 14 commits
  3. 07 Jul, 2014 4 commits
  4. 05 Jul, 2014 2 commits
  5. 04 Jul, 2014 1 commit
  6. 03 Jul, 2014 6 commits
  7. 02 Jul, 2014 2 commits
    • Cristian Staretu's avatar
      archive/tar: reuse temporary buffer in readHeader · 61ccc1f0
      Cristian Staretu authored
      A temporary 512 bytes buffer is allocated for every call to
      readHeader. This buffer isn't returned to the caller and it could
      be reused to lower the number of memory allocations.
      
      This CL improves it by using a pool and zeroing out the buffer before
      putting it back into the pool.
      
      benchmark                  old ns/op     new ns/op     delta
      BenchmarkListFiles100k     545249903     538832687     -1.18%
      
      benchmark                  old allocs    new allocs    delta
      BenchmarkListFiles100k     2105167       2005692       -4.73%
      
      benchmark                  old bytes     new bytes     delta
      BenchmarkListFiles100k     105903472     54831527      -48.22%
      
      This improvement is very important if your code has to deal with a lot
      of tarballs which contain a lot of files.
      
      LGTM=dsymonds
      R=golang-codereviews, dave, dsymonds, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/108240044
      61ccc1f0
    • Cristian Staretu's avatar
      archive/tar: reuse temporary buffer in writeHeader · fe5a358a
      Cristian Staretu authored
      A temporary 512 bytes buffer is allocated for every call to
      writeHeader. This buffer could be reused the lower the number
      of memory allocations.
      
      benchmark                   old ns/op     new ns/op     delta
      BenchmarkWriteFiles100k     634622051     583810847     -8.01%
      
      benchmark                   old allocs     new allocs     delta
      BenchmarkWriteFiles100k     2701920        2602621        -3.68%
      
      benchmark                   old bytes     new bytes     delta
      BenchmarkWriteFiles100k     115383884     64349922      -44.23%
      
      This change is very important if your code has to write a lot of
      tarballs with a lot of files.
      
      LGTM=dsymonds
      R=golang-codereviews, dave, dsymonds
      CC=golang-codereviews
      https://golang.org/cl/107440043
      fe5a358a